Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grafana dashboard to handle wildcard scaledObject variables #6215

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix grafana dashboard to handle wildcard scaledObject variables #6215

wants to merge 3 commits into from
+7 −6

Conversation

alexkuretz
Copy link

@alexkuretz alexkuretz commented Oct 2, 2024 •
edited by JorTurFer
Loading

Provide a description of what has been changed

Grafana dashboard now properly handles wildcard scaledObject variables in graphs

Checklist

Fixes #6214

@alexkuretz
Fix grafana dashboard to handle wildcard scaledObject variables
d4c084b 
Signed-off-by: Alex Kuretz <alex@andersonopt.com>
@alexkuretz alexkuretz requested a review from a team as a code owner October 2, 2024 15:39
JorTurFer
JorTurFer reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Could you update the changelog with the issue? 🙏

@alexkuretz
Update changelog
ceeaa1b 
Signed-off-by: Alex Kuretz <alex@andersonopt.com>
@alexkuretz
Copy link
Author

CHANGELOG updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grafana dashboard doesn't handle wildcard scaledObject variables properly for some graphs
2 participants
@alexkuretz @JorTurFer