Kafka scaler fix for SASL plaintext auth #544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahmelsayed
approved these changes
Jan 16, 2020
| @@ -211,6 +211,11 @@ func getKafkaClients(metadata kafkaMetadata) (sarama.Client, sarama.ClusterAdmin | |||
| config.Net.SASL.Mechanism = sarama.SASLMechanism(sarama.SASLTypeSCRAMSHA512) | |||
| } | |||
|
|
|||
| if metadata.authMode == kafkaAuthModeForSaslPlaintext { | |||
| config.Net.SASL.Mechanism = sarama.SASLTypePlaintext | |||
| config.Net.TLS.Enable = true | |||
There was a problem hiding this comment.
If authMode is set to sasl_plaintext then why enabling TLS?
preflightsiren
pushed a commit
to preflightsiren/keda
that referenced
this pull request
Nov 7, 2021
Signed-off-by: Dimitris Tsioumas <dtsioumas@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Issue #543.
Updated the Kafka scaler to add
configparameters for Sarama client corresponding to SASL plaintext auth mode