From e7481762d005e67cb08fffd50f31a9c9226754d4 Mon Sep 17 00:00:00 2001 From: Jorge Turrado Ferrero Date: Tue, 23 Nov 2021 08:42:36 +0100 Subject: [PATCH] Add execution url in the pr-e2e triggering comment and fix problem related with not starting with (#2306) Signed-off-by: Jorge Turrado --- .github/workflows/pr-e2e.yml | 28 ++++++++++------------------ CHANGELOG.md | 1 + 2 files changed, 11 insertions(+), 18 deletions(-) diff --git a/.github/workflows/pr-e2e.yml b/.github/workflows/pr-e2e.yml index 41c5af04911..9a86e2e84f0 100644 --- a/.github/workflows/pr-e2e.yml +++ b/.github/workflows/pr-e2e.yml @@ -7,18 +7,10 @@ jobs: runs-on: ubuntu-latest name: Comment evaluate outputs: - run-e2e: ${{ steps.check-comment.outputs.triggered == 'true' && steps.check-permission.outputs.has-permission }} + run-e2e: ${{ startsWith(github.event.comment.body,'/run-e2e') && steps.check-permission.outputs.has-permission }} steps: - - uses: khan/pull-request-comment-trigger@master - id: check-comment - with: - trigger: '/run-e2e' - prefix_only: true - env: - GITHUB_TOKEN: '${{ secrets.GITHUB_TOKEN }}' - - name: Check user permission - if: steps.check-comment.outputs.triggered == 'true' + if: startsWith(github.event.comment.body,'/run-e2e') id: check-permission uses: scherermichael-oss/action-has-permission@master with: @@ -26,14 +18,6 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - name: React to comment with rocket - uses: dkershner6/reaction-action@v1 - if: steps.check-comment.outputs.triggered == 'true' && steps.check-permission.outputs.has-permission - with: - token: ${{ secrets.GITHUB_TOKEN }} - commentId: ${{ github.event.comment.id }} - reaction: "rocket" - run-test: needs: check runs-on: ubuntu-latest @@ -44,6 +28,14 @@ jobs: steps: - uses: actions/checkout@v2 + - name: Update comment with the execution url + uses: peter-evans/create-or-update-comment@v1 + with: + comment-id: ${{ github.event.comment.id }} + body: | + **Update:** You can check the progres [here](https://github.com/${{github.repository}}/actions/runs/${{github.run_id}}) + reactions: rocket + - name: Checkout Pull Request env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/CHANGELOG.md b/CHANGELOG.md index 050667a147a..543446eceb3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -74,6 +74,7 @@ - Add Makefile mockgen targets ([#2090](https://github.com/kedacore/keda/issues/2090)|[#2184](https://github.com/kedacore/keda/pull/2184)) - Drop support to `ValueMetricType` using cpu_memory_scaler ([#2218](https://github.com/kedacore/keda/issues/2218)) - Add github action to run e2e command "on-demand" ([#2241](https://github.com/kedacore/keda/issues/2241)) +- Add execution url in the pr-e2e triggering comment and fix problem related with not starting with ([#2306](https://github.com/kedacore/keda/issues/2306)) ## v2.4.0