Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm chart install errors out - Required value: must specify a handler type] #968

Closed
Tracked by #973
bbrala opened this issue Apr 5, 2024 · 10 comments
Closed
Tracked by #973
Labels
bug Something isn't working

Comments

@bbrala
Copy link

bbrala commented Apr 5, 2024

Report

When installing thorugh helm the external scaler breaks.

Pod "keda-add-ons-http-external-scaler-df47d4f48-mx66x" is invalid: [spec.containers[0].livenessProbe: Required value: must specify a handler type, spec.containers[0].readinessProbe: Required value: must specify a handler type]

Not sure why, all is fine if i remove that part, but that is kinda hard if i want to deploy with argo

Expected Behavior

external-scaler should work.

Actual Behavior

Errors when trying to sync the scaler

Steps to Reproduce the Problem

  1. Install though helm (keda, then the http addon)

Logs from KEDA HTTP operator

think not relevant

HTTP Add-on Version

0.7.0

Kubernetes Version

1.27

Platform

Other

Anything else?

No response

@bbrala bbrala added the bug Something isn't working label Apr 5, 2024
@bbrala
Copy link
Author

bbrala commented Apr 5, 2024

Might need to be here i guess?
kedacore/charts#622

@JorTurFer JorTurFer mentioned this issue Apr 9, 2024
13 tasks
@JorTurFer
Copy link
Member

Hello and sorry for the slow response :(
When does it fail? during the helm install/upgrade? I can't reproduce the issue, just deploying the chart 0.7.0 it works

@bbrala
Copy link
Author

bbrala commented Apr 12, 2024

Thats weird, let me check a few more things.

@bbrala
Copy link
Author

bbrala commented Apr 12, 2024

This is the yaml. Im really confused. One would say, the handler is grpc, so that is fine. o_O

I've tried a few things.

  1. Deploy with all the values (except the below adjustements)
  2. Deploy to own namespace
  3. Service side apply for sync over argocd.
  4. Delete the deployment, let it try again.
  5. Pray.

Not sure how i could debug this more.

Deployment:

apiVersion: apps/v1
kind: Deployment
metadata:
  annotations:
    deployment.kubernetes.io/revision: '1'
    kubectl.kubernetes.io/last-applied-configuration: >
      {"apiVersion":"apps/v1","kind":"Deployment","metadata":{"annotations":{},"labels":{"app.kubernetes.io/component":"scaler","app.kubernetes.io/instance":"keda-http-add-on-acc","app.kubernetes.io/managed-by":"Helm","app.kubernetes.io/part-of":"keda-add-ons-http","app.kubernetes.io/version":"0.7.0","argocd.argoproj.io/instance":"keda-http-add-on-acc","helm.sh/chart":"keda-add-ons-http-0.7.0"},"name":"keda-add-ons-http-external-scaler","namespace":"keda"},"spec":{"replicas":1,"selector":{"matchLabels":{"app.kubernetes.io/component":"scaler","app.kubernetes.io/instance":"keda-http-add-on-acc","app.kubernetes.io/managed-by":"Helm","app.kubernetes.io/part-of":"keda-add-ons-http","app.kubernetes.io/version":"0.7.0","helm.sh/chart":"keda-add-ons-http-0.7.0"}},"template":{"metadata":{"labels":{"app.kubernetes.io/component":"scaler","app.kubernetes.io/instance":"keda-http-add-on-acc","app.kubernetes.io/managed-by":"Helm","app.kubernetes.io/part-of":"keda-add-ons-http","app.kubernetes.io/version":"0.7.0","helm.sh/chart":"keda-add-ons-http-0.7.0"}},"spec":{"containers":[{"args":["--zap-log-level=info","--zap-encoder=console","--zap-time-encoding=rfc3339"],"env":[{"name":"KEDA_HTTP_SCALER_TARGET_ADMIN_DEPLOYMENT","value":"keda-add-ons-http-interceptor"},{"name":"KEDA_HTTP_SCALER_PORT","value":"9090"},{"name":"KEDA_HTTP_SCALER_TARGET_ADMIN_NAMESPACE","value":"keda"},{"name":"KEDA_HTTP_SCALER_TARGET_ADMIN_SERVICE","value":"keda-add-ons-http-interceptor-admin"},{"name":"KEDA_HTTP_SCALER_TARGET_ADMIN_PORT","value":"9090"},{"name":"KEDA_HTTP_SCALER_STREAM_INTERVAL_MS","value":"200"}],"image":"ghcr.io/kedacore/http-add-on-scaler:0.7.0","imagePullPolicy":"Always","livenessProbe":{"failureThreshold":6,"grpc":{"port":9090,"service":"liveness"},"periodSeconds":5,"successThreshold":1,"timeoutSeconds":5},"name":"keda-add-ons-http-external-scaler","ports":[{"containerPort":9090,"name":"grpc"}],"readinessProbe":{"failureThreshold":3,"grpc":{"port":9090,"service":"readiness"},"periodSeconds":5,"successThreshold":1,"timeoutSeconds":1},"resources":{"limits":{"cpu":0.5,"memory":"64Mi"},"requests":{"cpu":"250m","memory":"20Mi"}},"securityContext":{"allowPrivilegeEscalation":false,"capabilities":{"drop":["ALL"]},"privileged":false,"readOnlyRootFilesystem":true}}],"imagePullSecrets":[],"nodeSelector":{"kubernetes.io/os":"linux"},"securityContext":{"fsGroup":1000,"supplementalGroups":[1000]},"serviceAccountName":"keda-add-ons-http-external-scaler","terminationGracePeriodSeconds":10}}}}
  creationTimestamp: '2024-04-12T14:52:42Z'
  generation: 1
  labels:
    app.kubernetes.io/component: scaler
    app.kubernetes.io/instance: keda-http-add-on-acc
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/part-of: keda-add-ons-http
    app.kubernetes.io/version: 0.7.0
    argocd.argoproj.io/instance: keda-http-add-on-acc
    helm.sh/chart: keda-add-ons-http-0.7.0
  name: keda-add-ons-http-external-scaler
  namespace: keda
  resourceVersion: '365797780'
  uid: 90e58cc4-21c4-42cc-8f3a-081185bb10be
spec:
  progressDeadlineSeconds: 600
  replicas: 1
  revisionHistoryLimit: 10
  selector:
    matchLabels:
      app.kubernetes.io/component: scaler
      app.kubernetes.io/instance: keda-http-add-on-acc
      app.kubernetes.io/managed-by: Helm
      app.kubernetes.io/part-of: keda-add-ons-http
      app.kubernetes.io/version: 0.7.0
      helm.sh/chart: keda-add-ons-http-0.7.0
  strategy:
    rollingUpdate:
      maxSurge: 25%
      maxUnavailable: 25%
    type: RollingUpdate
  template:
    metadata:
      creationTimestamp: null
      labels:
        app.kubernetes.io/component: scaler
        app.kubernetes.io/instance: keda-http-add-on-acc
        app.kubernetes.io/managed-by: Helm
        app.kubernetes.io/part-of: keda-add-ons-http
        app.kubernetes.io/version: 0.7.0
        helm.sh/chart: keda-add-ons-http-0.7.0
    spec:
      containers:
        - args:
            - '--zap-log-level=info'
            - '--zap-encoder=console'
            - '--zap-time-encoding=rfc3339'
          env:
            - name: KEDA_HTTP_SCALER_TARGET_ADMIN_DEPLOYMENT
              value: keda-add-ons-http-interceptor
            - name: KEDA_HTTP_SCALER_PORT
              value: '9090'
            - name: KEDA_HTTP_SCALER_TARGET_ADMIN_NAMESPACE
              value: keda
            - name: KEDA_HTTP_SCALER_TARGET_ADMIN_SERVICE
              value: keda-add-ons-http-interceptor-admin
            - name: KEDA_HTTP_SCALER_TARGET_ADMIN_PORT
              value: '9090'
            - name: KEDA_HTTP_SCALER_STREAM_INTERVAL_MS
              value: '200'
          image: 'ghcr.io/kedacore/http-add-on-scaler:0.7.0'
          imagePullPolicy: Always
          livenessProbe:
            failureThreshold: 6
            grpc:
              port: 9090
              service: liveness
            periodSeconds: 5
            successThreshold: 1
            timeoutSeconds: 5
          name: keda-add-ons-http-external-scaler
          ports:
            - containerPort: 9090
              name: grpc
              protocol: TCP
          readinessProbe:
            failureThreshold: 3
            grpc:
              port: 9090
              service: readiness
            periodSeconds: 5
            successThreshold: 1
            timeoutSeconds: 1
          resources:
            limits:
              cpu: 500m
              memory: 64Mi
            requests:
              cpu: 250m
              memory: 20Mi
          securityContext:
            allowPrivilegeEscalation: false
            capabilities:
              drop:
                - ALL
            privileged: false
            readOnlyRootFilesystem: true
          terminationMessagePath: /dev/termination-log
          terminationMessagePolicy: File
      dnsPolicy: ClusterFirst
      nodeSelector:
        kubernetes.io/os: linux
      restartPolicy: Always
      schedulerName: default-scheduler
      securityContext:
        fsGroup: 1000
        supplementalGroups:
          - 1000
      serviceAccount: keda-add-ons-http-external-scaler
      serviceAccountName: keda-add-ons-http-external-scaler
      terminationGracePeriodSeconds: 10
status:
  conditions:
    - lastTransitionTime: '2024-04-12T14:52:43Z'
      lastUpdateTime: '2024-04-12T14:52:43Z'
      message: Created new replica set "keda-add-ons-http-external-scaler-df47d4f48"
      reason: NewReplicaSetCreated
      status: 'True'
      type: Progressing
    - lastTransitionTime: '2024-04-12T14:52:43Z'
      lastUpdateTime: '2024-04-12T14:52:43Z'
      message: Deployment does not have minimum availability.
      reason: MinimumReplicasUnavailable
      status: 'False'
      type: Available
    - lastTransitionTime: '2024-04-12T14:52:43Z'
      lastUpdateTime: '2024-04-12T14:52:43Z'
      message: >-
        Pod "keda-add-ons-http-external-scaler-df47d4f48-85mmr" is invalid:
        [spec.containers[0].livenessProbe: Required value: must specify a
        handler type, spec.containers[0].readinessProbe: Required value: must
        specify a handler type]
      reason: FailedCreate
      status: 'True'
      type: ReplicaFailure
  observedGeneration: 1
  unavailableReplicas: 1

Replicaset

apiVersion: apps/v1
kind: ReplicaSet
metadata:
  annotations:
    deployment.kubernetes.io/desired-replicas: '1'
    deployment.kubernetes.io/max-replicas: '2'
    deployment.kubernetes.io/revision: '1'
  creationTimestamp: '2024-04-12T14:52:42Z'
  generation: 1
  labels:
    app.kubernetes.io/component: scaler
    app.kubernetes.io/instance: keda-http-add-on-acc
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/part-of: keda-add-ons-http
    app.kubernetes.io/version: 0.7.0
    helm.sh/chart: keda-add-ons-http-0.7.0
    pod-template-hash: df47d4f48
  name: keda-add-ons-http-external-scaler-df47d4f48
  namespace: keda
  ownerReferences:
    - apiVersion: apps/v1
      blockOwnerDeletion: true
      controller: true
      kind: Deployment
      name: keda-add-ons-http-external-scaler
      uid: 90e58cc4-21c4-42cc-8f3a-081185bb10be
  resourceVersion: '365797766'
  uid: 4a0c2511-2f4b-4100-84f1-d587d6aabb14
spec:
  replicas: 1
  selector:
    matchLabels:
      app.kubernetes.io/component: scaler
      app.kubernetes.io/instance: keda-http-add-on-acc
      app.kubernetes.io/managed-by: Helm
      app.kubernetes.io/part-of: keda-add-ons-http
      app.kubernetes.io/version: 0.7.0
      helm.sh/chart: keda-add-ons-http-0.7.0
      pod-template-hash: df47d4f48
  template:
    metadata:
      creationTimestamp: null
      labels:
        app.kubernetes.io/component: scaler
        app.kubernetes.io/instance: keda-http-add-on-acc
        app.kubernetes.io/managed-by: Helm
        app.kubernetes.io/part-of: keda-add-ons-http
        app.kubernetes.io/version: 0.7.0
        helm.sh/chart: keda-add-ons-http-0.7.0
        pod-template-hash: df47d4f48
    spec:
      containers:
        - args:
            - '--zap-log-level=info'
            - '--zap-encoder=console'
            - '--zap-time-encoding=rfc3339'
          env:
            - name: KEDA_HTTP_SCALER_TARGET_ADMIN_DEPLOYMENT
              value: keda-add-ons-http-interceptor
            - name: KEDA_HTTP_SCALER_PORT
              value: '9090'
            - name: KEDA_HTTP_SCALER_TARGET_ADMIN_NAMESPACE
              value: keda
            - name: KEDA_HTTP_SCALER_TARGET_ADMIN_SERVICE
              value: keda-add-ons-http-interceptor-admin
            - name: KEDA_HTTP_SCALER_TARGET_ADMIN_PORT
              value: '9090'
            - name: KEDA_HTTP_SCALER_STREAM_INTERVAL_MS
              value: '200'
          image: 'ghcr.io/kedacore/http-add-on-scaler:0.7.0'
          imagePullPolicy: Always
          livenessProbe:
            failureThreshold: 6
            grpc:
              port: 9090
              service: liveness
            periodSeconds: 5
            successThreshold: 1
            timeoutSeconds: 5
          name: keda-add-ons-http-external-scaler
          ports:
            - containerPort: 9090
              name: grpc
              protocol: TCP
          readinessProbe:
            failureThreshold: 3
            grpc:
              port: 9090
              service: readiness
            periodSeconds: 5
            successThreshold: 1
            timeoutSeconds: 1
          resources:
            limits:
              cpu: 500m
              memory: 64Mi
            requests:
              cpu: 250m
              memory: 20Mi
          securityContext:
            allowPrivilegeEscalation: false
            capabilities:
              drop:
                - ALL
            privileged: false
            readOnlyRootFilesystem: true
          terminationMessagePath: /dev/termination-log
          terminationMessagePolicy: File
      dnsPolicy: ClusterFirst
      nodeSelector:
        kubernetes.io/os: linux
      restartPolicy: Always
      schedulerName: default-scheduler
      securityContext:
        fsGroup: 1000
        supplementalGroups:
          - 1000
      serviceAccount: keda-add-ons-http-external-scaler
      serviceAccountName: keda-add-ons-http-external-scaler
      terminationGracePeriodSeconds: 10
status:
  conditions:
    - lastTransitionTime: '2024-04-12T14:52:43Z'
      message: >-
        Pod "keda-add-ons-http-external-scaler-df47d4f48-85mmr" is invalid:
        [spec.containers[0].livenessProbe: Required value: must specify a
        handler type, spec.containers[0].readinessProbe: Required value: must
        specify a handler type]
      reason: FailedCreate
      status: 'True'
      type: ReplicaFailure
  observedGeneration: 1
  replicas: 0

The values used to deploy the help are slightly shortened, tried also do do the full values.yaml, but no go.

values.yaml

scaler:
  # -- Number of replicas
  replicas: 1

  # -- The number of "target requests" that the external scaler will report to KEDA for the interceptor's scaling metrics. See the [KEDA external scaler documentation](https://keda.sh/docs/2.4/concepts/external-scalers/) for details on target requests.
  pendingRequestsInterceptor: 200
  # -- Interval in ms for communicating IsActive to KEDA
  streamInterval: 200
  # -- Node selector for pod scheduling ([docs](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/))
  nodeSelector: {}
  # -- Tolerations for pod scheduling ([docs](https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/))
  tolerations: []
  # -- Affinity for pod scheduling ([docs](https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes-using-node-affinity/))
  affinity: {}
  resources:
    limits:
      cpu: 0.5
      memory: 64Mi
    requests:
      cpu: 250m
      memory: 20Mi

interceptor:
  replicas:
    # -- The minimum number of interceptor replicas that should ever be running
    min: 1
    # -- The maximum number of interceptor replicas that should ever be running
    max: 3
    # -- The maximum time the interceptor should wait for an HTTP request to reach a backend before it is considered a failure
    waitTimeout: 30s

  # configuration for the ScaledObject resource for the
  # interceptor
  scaledObject:
    # -- The interval (in milliseconds) that KEDA should poll the external scaler to fetch scaling metrics about the interceptor
    pollingInterval: 1

  # -- How long the interceptor waits to establish TCP connections with backends before failing a request.
  tcpConnectTimeout: 1000ms
  # -- The interceptor's connection keep alive timeout
  keepAlive: 1s
  # -- How long the interceptor will wait between forwarding a request to a backend and receiving response headers back before failing the request
  responseHeaderTimeout: 1000ms
  # -- How often (in milliseconds) the interceptor does a full refresh of its endpoints cache. The interceptor will also use Kubernetes events to stay up-to-date with the endpoints cache changes. This duration is the maximum time it will take to see changes to the endpoints.
  endpointsCachePollingIntervalMS: 250
  # -- Whether or not the interceptor should force requests to use HTTP/2
  forceHTTP2: false
  # -- The maximum number of idle connections allowed in the interceptor's in-memory connection pool. Set to 0 to indicate no limit
  maxIdleConns: 20
  # -- The timeout after which any idle connection is closed and removed from the interceptor's in-memory connection pool.
  idleConnTimeout: 90s
  # -- The maximum amount of time the interceptor will wait for a TLS handshake. Set to zero to indicate no timeout.
  tlsHandshakeTimeout: 10s
  # -- Special handling for responses with "Expect: 100-continue" response headers. see https://pkg.go.dev/net/http#Transport under the 'ExpectContinueTimeout' field for more details
  expectContinueTimeout: 1s
  # -- Node selector for pod scheduling ([docs](https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/))
  nodeSelector: {}
  # -- Tolerations for pod scheduling ([docs](https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/))
  tolerations: []
  # -- Affinity for pod scheduling ([docs](https://kubernetes.io/docs/tasks/configure-pod-container/assign-pods-nodes-using-node-affinity/))
  affinity: {}
  # interceptor pod resource limits
  resources:
    # -- The CPU/memory resource limit for the operator component
    limits:
      cpu: 0.5
      memory: 64Mi
    # -- The CPU/memory resource request for the operator component
    requests:
      cpu: 250m
      memory: 20Mi

@JorTurFer
Copy link
Member

hum....
Interesting because my Deployment looks similar:

apiVersion: apps/v1
kind: Deployment
metadata:
  name: keda-add-ons-http-external-scaler
  namespace: keda
  uid: 4f300a30-35c3-4e86-a4b7-f1371e17d039
  resourceVersion: '49599372'
  generation: 1
  creationTimestamp: '2024-04-11T22:13:47Z'
  labels:
    app.kubernetes.io/component: scaler
    app.kubernetes.io/instance: keda-add-ons-http-1712873622
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/part-of: keda-add-ons-http
    app.kubernetes.io/version: 0.7.0
    helm.sh/chart: keda-add-ons-http-0.7.0
  annotations:
    deployment.kubernetes.io/revision: '1'
    meta.helm.sh/release-name: keda-add-ons-http-1712873622
    meta.helm.sh/release-namespace: keda
  managedFields:
    - manager: helm
      operation: Update
      apiVersion: apps/v1
      time: '2024-04-11T22:13:47Z'
      fieldsType: FieldsV1
      fieldsV1:
        f:metadata:
          f:annotations:
            .: {}
            f:meta.helm.sh/release-name: {}
            f:meta.helm.sh/release-namespace: {}
          f:labels:
            .: {}
            f:app.kubernetes.io/component: {}
            f:app.kubernetes.io/instance: {}
            f:app.kubernetes.io/managed-by: {}
            f:app.kubernetes.io/part-of: {}
            f:app.kubernetes.io/version: {}
            f:helm.sh/chart: {}
        f:spec:
          f:progressDeadlineSeconds: {}
          f:replicas: {}
          f:revisionHistoryLimit: {}
          f:selector: {}
          f:strategy:
            f:rollingUpdate:
              .: {}
              f:maxSurge: {}
              f:maxUnavailable: {}
            f:type: {}
          f:template:
            f:metadata:
              f:labels:
                .: {}
                f:app.kubernetes.io/component: {}
                f:app.kubernetes.io/instance: {}
                f:app.kubernetes.io/managed-by: {}
                f:app.kubernetes.io/part-of: {}
                f:app.kubernetes.io/version: {}
                f:helm.sh/chart: {}
            f:spec:
              f:containers:
                k:{"name":"keda-add-ons-http-external-scaler"}:
                  .: {}
                  f:args: {}
                  f:env:
                    .: {}
                    k:{"name":"KEDA_HTTP_SCALER_PORT"}:
                      .: {}
                      f:name: {}
                      f:value: {}
                    k:{"name":"KEDA_HTTP_SCALER_STREAM_INTERVAL_MS"}:
                      .: {}
                      f:name: {}
                      f:value: {}
                    k:{"name":"KEDA_HTTP_SCALER_TARGET_ADMIN_DEPLOYMENT"}:
                      .: {}
                      f:name: {}
                      f:value: {}
                    k:{"name":"KEDA_HTTP_SCALER_TARGET_ADMIN_NAMESPACE"}:
                      .: {}
                      f:name: {}
                      f:value: {}
                    k:{"name":"KEDA_HTTP_SCALER_TARGET_ADMIN_PORT"}:
                      .: {}
                      f:name: {}
                      f:value: {}
                    k:{"name":"KEDA_HTTP_SCALER_TARGET_ADMIN_SERVICE"}:
                      .: {}
                      f:name: {}
                      f:value: {}
                  f:image: {}
                  f:imagePullPolicy: {}
                  f:livenessProbe:
                    .: {}
                    f:failureThreshold: {}
                    f:grpc:
                      .: {}
                      f:port: {}
                      f:service: {}
                    f:periodSeconds: {}
                    f:successThreshold: {}
                    f:timeoutSeconds: {}
                  f:name: {}
                  f:ports:
                    .: {}
                    k:{"containerPort":9090,"protocol":"TCP"}:
                      .: {}
                      f:containerPort: {}
                      f:name: {}
                      f:protocol: {}
                  f:readinessProbe:
                    .: {}
                    f:failureThreshold: {}
                    f:grpc:
                      .: {}
                      f:port: {}
                      f:service: {}
                    f:periodSeconds: {}
                    f:successThreshold: {}
                    f:timeoutSeconds: {}
                  f:resources:
                    .: {}
                    f:limits:
                      .: {}
                      f:cpu: {}
                      f:memory: {}
                    f:requests:
                      .: {}
                      f:cpu: {}
                      f:memory: {}
                  f:securityContext:
                    .: {}
                    f:allowPrivilegeEscalation: {}
                    f:capabilities:
                      .: {}
                      f:drop: {}
                    f:privileged: {}
                    f:readOnlyRootFilesystem: {}
                  f:terminationMessagePath: {}
                  f:terminationMessagePolicy: {}
              f:dnsPolicy: {}
              f:nodeSelector: {}
              f:restartPolicy: {}
              f:schedulerName: {}
              f:securityContext:
                .: {}
                f:fsGroup: {}
                f:supplementalGroups: {}
              f:serviceAccount: {}
              f:serviceAccountName: {}
              f:terminationGracePeriodSeconds: {}
    - manager: kube-controller-manager
      operation: Update
      apiVersion: apps/v1
      time: '2024-04-11T22:14:03Z'
      fieldsType: FieldsV1
      fieldsV1:
        f:metadata:
          f:annotations:
            f:deployment.kubernetes.io/revision: {}
        f:status:
          f:availableReplicas: {}
          f:conditions:
            .: {}
            k:{"type":"Available"}:
              .: {}
              f:lastTransitionTime: {}
              f:lastUpdateTime: {}
              f:message: {}
              f:reason: {}
              f:status: {}
              f:type: {}
            k:{"type":"Progressing"}:
              .: {}
              f:lastTransitionTime: {}
              f:lastUpdateTime: {}
              f:message: {}
              f:reason: {}
              f:status: {}
              f:type: {}
          f:observedGeneration: {}
          f:readyReplicas: {}
          f:replicas: {}
          f:updatedReplicas: {}
      subresource: status
  selfLink: /apis/apps/v1/namespaces/keda/deployments/keda-add-ons-http-external-scaler
status:
  observedGeneration: 1
  replicas: 3
  updatedReplicas: 3
  readyReplicas: 3
  availableReplicas: 3
  conditions:
    - type: Available
      status: 'True'
      lastUpdateTime: '2024-04-11T22:14:03Z'
      lastTransitionTime: '2024-04-11T22:14:03Z'
      reason: MinimumReplicasAvailable
      message: Deployment has minimum availability.
    - type: Progressing
      status: 'True'
      lastUpdateTime: '2024-04-11T22:14:03Z'
      lastTransitionTime: '2024-04-11T22:13:47Z'
      reason: NewReplicaSetAvailable
      message: >-
        ReplicaSet "keda-add-ons-http-external-scaler-55cd498649" has
        successfully progressed.
spec:
  replicas: 3
  selector:
    matchLabels:
      app.kubernetes.io/component: scaler
      app.kubernetes.io/instance: keda-add-ons-http-1712873622
      app.kubernetes.io/managed-by: Helm
      app.kubernetes.io/part-of: keda-add-ons-http
      app.kubernetes.io/version: 0.7.0
      helm.sh/chart: keda-add-ons-http-0.7.0
  template:
    metadata:
      creationTimestamp: null
      labels:
        app.kubernetes.io/component: scaler
        app.kubernetes.io/instance: keda-add-ons-http-1712873622
        app.kubernetes.io/managed-by: Helm
        app.kubernetes.io/part-of: keda-add-ons-http
        app.kubernetes.io/version: 0.7.0
        helm.sh/chart: keda-add-ons-http-0.7.0
    spec:
      containers:
        - name: keda-add-ons-http-external-scaler
          image: ghcr.io/kedacore/http-add-on-scaler:0.7.0
          args:
            - '--zap-log-level=info'
            - '--zap-encoder=console'
            - '--zap-time-encoding=rfc3339'
          ports:
            - name: grpc
              containerPort: 9090
              protocol: TCP
          env:
            - name: KEDA_HTTP_SCALER_TARGET_ADMIN_DEPLOYMENT
              value: keda-add-ons-http-interceptor
            - name: KEDA_HTTP_SCALER_PORT
              value: '9090'
            - name: KEDA_HTTP_SCALER_TARGET_ADMIN_NAMESPACE
              value: keda
            - name: KEDA_HTTP_SCALER_TARGET_ADMIN_SERVICE
              value: keda-add-ons-http-interceptor-admin
            - name: KEDA_HTTP_SCALER_TARGET_ADMIN_PORT
              value: '9090'
            - name: KEDA_HTTP_SCALER_STREAM_INTERVAL_MS
              value: '200'
          resources:
            limits:
              cpu: 500m
              memory: 64Mi
            requests:
              cpu: 250m
              memory: 20Mi
          livenessProbe:
            grpc:
              port: 9090
              service: liveness
            timeoutSeconds: 5
            periodSeconds: 5
            successThreshold: 1
            failureThreshold: 6
          readinessProbe:
            grpc:
              port: 9090
              service: readiness
            timeoutSeconds: 1
            periodSeconds: 5
            successThreshold: 1
            failureThreshold: 3
          terminationMessagePath: /dev/termination-log
          terminationMessagePolicy: File
          imagePullPolicy: Always
          securityContext:
            capabilities:
              drop:
                - ALL
            privileged: false
            readOnlyRootFilesystem: true
            allowPrivilegeEscalation: false
      restartPolicy: Always
      terminationGracePeriodSeconds: 10
      dnsPolicy: ClusterFirst
      nodeSelector:
        kubernetes.io/os: linux
      serviceAccountName: keda-add-ons-http-external-scaler
      serviceAccount: keda-add-ons-http-external-scaler
      securityContext:
        supplementalGroups:
          - 1000
        fsGroup: 1000
      schedulerName: default-scheduler
  strategy:
    type: RollingUpdate
    rollingUpdate:
      maxUnavailable: 25%
      maxSurge: 25%
  revisionHistoryLimit: 10
  progressDeadlineSeconds: 600

Can you confirm that you are using k8s 1.27?

@bbrala
Copy link
Author

bbrala commented Apr 12, 2024

Yes just confirmed. 1.27. Can't check the minor while on mobile hehe

@bbrala
Copy link
Author

bbrala commented Apr 12, 2024

Yeah the 2 deployments pretty much look the same, which is interesting. I'll open an issue to the hosting company, see if they have a clue

@JorTurFer
Copy link
Member

JorTurFer commented Apr 12, 2024

I just installed the helm without any extra value. I mean, helm install http-add-on kedacore/keda-add-ons-http --create-namespace --namespace keda

@bbrala
Copy link
Author

bbrala commented Apr 12, 2024

Same issue without values.

When nog using argo I had the same issue unfortunately.

I'll wait for a response externally see if that might give some insight.

@bbrala
Copy link
Author

bbrala commented Apr 15, 2024

This is the reply. It is an issue with bonsai bankvault mutating the resources. Sorry for the confusion.

Hi,
We have found the issue! This is a bug in the current version of the vault-webhook. The mutating webhook is changing the probes in a way that it is not valid anymore for kube. When removing the mutating webhook the apply of the helm chart and the basic examples for this works.

@bbrala bbrala closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants