Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OTEL Env vars don't respect spec #1031

Closed
Tracked by #965
JorTurFer opened this issue May 18, 2024 · 3 comments · Fixed by #1039
Closed
Tracked by #965

OTEL Env vars don't respect spec #1031

JorTurFer opened this issue May 18, 2024 · 3 comments · Fixed by #1039
Labels
bug Something isn't working

Comments

@JorTurFer
Copy link
Member

JorTurFer commented May 18, 2024

Report

We have merged the support for OTEL metrics, but the envs used don't respect the spec:
https://opentelemetry.io/docs/specs/otel/protocol/exporter/

Expected Behavior

We should respect the spec, we use KEDA_HTTP_OTEL_HTTP_COLLECTOR_ENDPOINT when it should be OTEL_EXPORTER_OTLP_ENDPOINT (and probably supported automatically under the hood), or KEDA_HTTP_OTEL_HTTP_COLLECTOR_INSECURE instead of OTEL_EXPORTER_OTLP_INSECURE and other cases

@zorocloud
Copy link
Contributor

Happy to align these if someone isn't already working on this issue.

@JorTurFer
Copy link
Member Author

Thanks a lot ❤️

@zorocloud
Copy link
Contributor

PR raised @JorTurFer. Shout if I've missed anything 🙂.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants