Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http-add-on] admin-port in http-add-on-operator does not exist anymore when using latest commit #516

Closed
jocelynthode opened this issue Aug 31, 2023 · 4 comments · Fixed by #523
Labels
bug Something isn't working

Comments

@jocelynthode
Copy link
Contributor

The operator cannot start when using latest http-add-on commit

This is due to https://github.com/kedacore/charts/blob/main/http-add-on/templates/deployment-operator.yaml#L53 which apparently does not exist anymore in latest operator code and should thus be removed from the chart manifests as well as its variable.

Expected Behavior

The operator should start

Actual Behavior

The operator crashes with the help message

Steps to Reproduce the Problem

  1. Use commit 0321ee0 from keda-http-add-on in helm chart
  2. Operator crashes
@jocelynthode jocelynthode added the bug Something isn't working label Aug 31, 2023
@jocelynthode
Copy link
Contributor Author

@JorTurFer: Would you like me to submit a PR to remove this admin-port or did I misunderstand why it's not working?

@JorTurFer
Copy link
Member

@JorTurFer: Would you like me to submit a PR to remove this admin-port or did I misunderstand why it's not working?

I'm reviewing the whole chart to be sure that it works

@JorTurFer
Copy link
Member

I think that this PR aligns the helm chart with latest version. Once it's merged you can use it (pulling it and deploying it locally or building your own chart) if you want to try it.

I have added a validation check for the interceptor ScaledObject, so I hope that the issue won't come back as a regression in the future 🤞

@jocelynthode
Copy link
Contributor Author

Thanks, yes it looks like it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants