From 72452e9fce4c42dc843c1157c19c08d39e3996df Mon Sep 17 00:00:00 2001 From: nathanfaucett Date: Fri, 5 Sep 2014 21:16:50 -0500 Subject: [PATCH] fix: Wrap url.parse to always return an object for query property Closes #1182 --- lib/middleware/karma.js | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/middleware/karma.js b/lib/middleware/karma.js index 65fec33ef..3d3cf4a0c 100644 --- a/lib/middleware/karma.js +++ b/lib/middleware/karma.js @@ -13,7 +13,13 @@ var path = require('path'); var util = require('util'); -var urlparse = require('url').parse; +var url = require('url'); + +var urlparse = function(urlStr) { + var urlObj = url.parse(urlStr, true); + urlObj.query = urlObj.query || {}; + return urlObj; +}; var common = require('./common'); @@ -36,7 +42,7 @@ var filePathToUrlPath = function(filePath, basePath) { var getXUACompatibleMetaElement = function(url) { var tag = ''; - var urlObj = urlparse(url, true); + var urlObj = urlparse(url); if (urlObj.query['x-ua-compatible']) { tag = '\n'; @@ -46,7 +52,7 @@ var getXUACompatibleMetaElement = function(url) { var getXUACompatibleUrl = function(url) { var value = ''; - var urlObj = urlparse(url, true); + var urlObj = urlparse(url); if (urlObj.query['x-ua-compatible']) { value = '?x-ua-compatible=' + encodeURIComponent(urlObj.query['x-ua-compatible']); }