Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues hook missing?Group didn’t get any UrlCard #109

Open
JesseWeb opened this issue Apr 17, 2020 · 3 comments
Open

Issues hook missing?Group didn’t get any UrlCard #109

JesseWeb opened this issue Apr 17, 2020 · 3 comments
Labels
question Further information is requested

Comments

@JesseWeb
Copy link
Contributor

this problem occurs frequently lately.

@huan
Copy link
Collaborator

huan commented Apr 17, 2020

We have serval issues related to the webhook message lost problem, and most cases were caused by the bot and our HTTP service:

  1. If the bot is offline, then the message sending will fail
  2. If the message sending is failed, we should return a 500 error to the GitHub webhook caller.

Currently, we always return 200 from our webhook processer, which caused the GitHub will not be able to redeliver the failed messages.

To be fixed.

P.S. Please feel free to send an oss text message to our bot, so that you can join our ChatOps room. You can get more information in that room.

@huan huan added the question Further information is requested label Apr 17, 2020
@JesseWeb
Copy link
Contributor Author

well I’m just start to reading source code of this project. maybe the durable queue can be the “bot offline issue” solution?

@huan
Copy link
Collaborator

huan commented Apr 17, 2020

Yes, that might be another solution for this issue.

I hope you enjoy the reading, and please feel free to let me know if you have questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants