-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ServiceLB return ingress address list in alphabetical order, instead of sorted by address family #8704
Milestone
Comments
This was referenced Nov 14, 2023
Pending fix for #8901 |
Validated on master branch with commit 96ebb96Environment DetailsInfrastructure
Node(s) CPU architecture, OS, and Version:
Cluster Configuration:
Config.yaml:
Testing Steps
Replication Results:
Validation Results:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ServiceLB should sort the
status.loadBalancer.ingress
address list by address family first, then by IP. Other Service fields such asspec.clusterIP
always sort entries in the order specified byspec.ipFamilies
. Nodes do the same instatus.addresses
andstatus.podCIDRs
, and Pods instatus.podIPs
.Example:
We should use
sort.Slice()
and a custom sort function, instead of just usingsort.Strings()
There may also be code from upstream that we could call or reuse.k3s/pkg/cloudprovider/servicelb.go
Line 288 in 5b6b968
The text was updated successfully, but these errors were encountered: