Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nats.go module info not accurate in go.mod for v1.27.5+k3s1 #8320

Closed
ChenQi1989 opened this issue Sep 8, 2023 · 3 comments
Closed

nats.go module info not accurate in go.mod for v1.27.5+k3s1 #8320

ChenQi1989 opened this issue Sep 8, 2023 · 3 comments

Comments

@ChenQi1989
Copy link

Environmental Info:
K3s Version:
commit 8d074ec (HEAD -> 1.27.5, tag: v1.27.5-rc3+k3s1, tag: v1.27.5+k3s1, origin/release-1.27)

Steps To Reproduce:
$ grep nats.go go.mod
github.com/nats-io/nats.go v1.27.1-0.20230619112143-ec00e662324e // indirect

The revision 'ec00e662324e' does not even exist in https://github.com/nats-io/nats.go.git

nats.go [2][0] $ git show ec00e662324e
fatal: ambiguous argument 'ec00e662324e': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git [...] -- [...]'

Expected behavior:

The revision specified in go.mod file should be a valid one.

Actual behavior:

The revision ec00e662324e does not exist for nats.go.

@brandond
Copy link
Member

brandond commented Sep 8, 2023

It pointed at a commit in branch in the nats repo that has been deleted by upstream. We have no control over what other projects do with their repos.

@brandond brandond closed this as completed Sep 8, 2023
@ChenQi1989
Copy link
Author

@brandond If kine gets a fix to bump the version (k3s-io/kine#206), should the k3s origin/release-1.27 branch also gets a fix? I can see that in k3s mater branch, the version has already been bumped to v1.27.1.

@brandond
Copy link
Member

brandond commented Sep 8, 2023

It will eventually, yes. Probably as part of next months release cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants