Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support allowed_users and admin_users #260

Closed
consideRatio opened this issue Sep 15, 2024 · 3 comments
Closed

Support allowed_users and admin_users #260

consideRatio opened this issue Sep 15, 2024 · 3 comments
Labels

Comments

@consideRatio
Copy link
Member

allowed_user and admin_users are config options from the Authenticator base class. They should work in this authenticator class as well, allowing usernames to be listed in order to be allowed access.

@consideRatio
Copy link
Member Author

I think #269 is a step towards making sure that allowed_user and admin_users works more as expected, where for example users doesn't have to be listed both in a allowed group and individually in allowed_users.

@minrk
Copy link
Member

minrk commented Sep 17, 2024

#269 actually doesn't fix allowed_users (yet) but it's a tiny change to do so. I'll make sure there's a test.

@minrk
Copy link
Member

minrk commented Sep 18, 2024

This is now fixed and tested by #269

@minrk minrk closed this as completed Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants