Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put all config in a k8s Secret, don't split it up into ConfigMap/Secret #1176

Closed
consideRatio opened this issue Oct 29, 2020 · 0 comments · Fixed by #1179
Closed

Put all config in a k8s Secret, don't split it up into ConfigMap/Secret #1176

consideRatio opened this issue Oct 29, 2020 · 0 comments · Fixed by #1179
Labels
maintenance Under the hood improvements and fixes

Comments

@consideRatio
Copy link
Member

We currently have a configmap.yaml and secret.yaml, and split up information from .Values into them based on if the content is sensitive or not. This is a cumbersome practice that adds complexity which is prone to break - this is based on experience of it breaking :D In z2jh we decided to merge them.

I added a note in the configmap saying....

  FIXME: Stop splitting up parts into configmap/secret as it adds complexity,
         instead only use a secret. For the equivalent PR in z2jh, see:
         https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/1682

jupyterhub/zero-to-jupyterhub-k8s#1682 can provide an example on how we went about it in z2jh, and I suggest that we mimic this here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Under the hood improvements and fixes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant