Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more flexible in finding solution delimeters #551

Closed
jhamrick opened this issue Sep 9, 2016 · 3 comments · Fixed by #614
Closed

Be more flexible in finding solution delimeters #551

jhamrick opened this issue Sep 9, 2016 · 3 comments · Fixed by #614
Labels
Milestone

Comments

@jhamrick
Copy link
Member

jhamrick commented Sep 9, 2016

See the discussion in #542

This would essentially revert #523, which is unfortunate in that it will result in yet another API change, but I think it will ultimately make things simpler as @dsblank suggests.

@jhamrick jhamrick added this to the 0.4.0 milestone Sep 9, 2016
@jhamrick
Copy link
Member Author

jhamrick commented Sep 9, 2016

Probably whatever PR implements this should also tackle #422 too.

@dsblank
Copy link
Member

dsblank commented Sep 9, 2016

You could probably still allow the old delimiters to work too, and slowly deprecate them.

@jhamrick
Copy link
Member Author

jhamrick commented Sep 9, 2016

Yes, though the way the current delimeters work hasn't been in an official release yet, so I'm more ok with breaking those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants