This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
Add common settings and tools #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidanthoff What do you think? |
davidanthoff
approved these changes
Sep 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in microsoft/vscode-dev-containers#450 I updated the container definition. Before removing the draft status I would like to double check the following:
Currently, the container definition refers to the common-debian script from https://github.com/microsoft/vscode-dev-containers/master/script-library/common-debian.sh. I wasn't sure what would be the best approach. Either add a copy to our repo or to have it point to the microsoft/vscode-dev-containers as an external dependency. What would you prefer?