Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default registerExitHandler to false #9

Open
Asarew opened this issue May 18, 2020 · 0 comments
Open

set default registerExitHandler to false #9

Asarew opened this issue May 18, 2020 · 0 comments

Comments

@Asarew
Copy link

Asarew commented May 18, 2020

I can't figure out any logical reason why a 'Logging' module should be responsible for shuttingdown an application. This causes the exit logic of nestjs to break.
If you want to flush the logger use the exit hooks provided by nestjs: beforeApplicationShutdown.

Besides this """super logical logic""" being in this package, it's also not documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant