-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error on component resize when view prop has changed #725
Labels
Comments
Don't know if abandoning string refs would do anything about this, but perhaps should be done anyway. Will do tests but maybe someone else is faster than me. |
marwej
changed the title
Error on window resize when view prop has changed
Error on component resize when view prop has changed
Feb 13, 2018
I've run into same message after navigating from page with a calendar view to one without, and then resizing app. Is this because the TimeGrid resize listener never gets removed? |
I can confirm the behavior @mprobus has described. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug
What's the current behavior?
When the view is changed (with new value in prop) the calendar throws an error on component resize.
"Uncaught TypeError: Cannot read property 'scrollHeight' of undefined"
https://github.com/intljusticemission/react-big-calendar/blob/3903fd7066dafcc7dd528fa9889748cf75e0e5df/src/TimeGrid.js#L470
Haven't succeeded with reproducing the problem yet though (I'll keep trying):
https://codesandbox.io/s/wyzj8o3228
What's the expected behavior?
No errors.
The text was updated successfully, but these errors were encountered: