Merge pull request #153 from joomlatools/hotfix/152-share

#152: when creating a screen also provide a -S name for easy killing …
joomlatools · Jul 17, 2019 · ed2a184 · ed2a184
2 parents f5421b5 + bb59fdf
commit ed2a184
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/puppet/environments/box/modules/profiles/files/box/cli/scripts/Command/Share.php b/puppet/environments/box/modules/profiles/files/box/cli/scripts/Command/Share.php
@@ -50,6 +50,9 @@ protected function execute(InputInterface $input, OutputInterface $output)
         $this->www = $input->getOption('www');
         $this->site = $input->getArgument('site');
 
+        //first lets clear any existing ngrok screens
+        `screen -S ngrokShare -X quit`;
+
         $this->_check();
 
         //in order to share joomla.box there can't be a vhost override
@@ -128,8 +131,8 @@ protected function _launchNgrok()
             $ngrok_command = "ngrok http $this->site.test:80";
         }
 
-        //launch ngrok and create a new screen to keep the user on the foreground
-        `screen -d -m $ngrok_command`;
+        //launch ngrok and create a new screen (with screen name) to keep the user on the foreground
+        `screen -S ngrokShare -d -m $ngrok_command`;
 
         //wait for the api to return connection details
         do