Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deps to v.1.3.0 of html-minifier #48

Closed
igoradamenko opened this issue Mar 22, 2016 · 3 comments
Closed

Update deps to v.1.3.0 of html-minifier #48

igoradamenko opened this issue Mar 22, 2016 · 3 comments

Comments

@igoradamenko
Copy link
Contributor

Hello!

Why are you not updating html-minifier version? I am getting errors in minified version with your plugin ('cause it depends on v.1.0.0). Please check this out: kangax/html-minifier#581

I've tried update to v.1.3.0 and run tests. All of them are passing.
@jonschlinkert
Copy link
Owner

Why are you not updating html-minifier version?

why didn't you do a pr instead of wasting time writing about it?

@igoradamenko igoradamenko mentioned this issue Mar 22, 2016
Merged
@igoradamenko
Copy link
Contributor Author

Sorry about that. I just looking to PRs and found closed Set the html-minifier dependency to 1.2.0.

Here it is: #49

@jonschlinkert
Copy link
Owner

no worries, and sorry as well for my response. we've had a lot of issues about recent bugs in html-minifier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonschlinkert @igoradamenko