Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angel Parrot #159

Merged
merged 3 commits into from
Oct 20, 2017
Merged

Angel Parrot #159

merged 3 commits into from
Oct 20, 2017

Conversation

trcliao
Copy link
Contributor

@trcliao trcliao commented Oct 12, 2017

Counterpart to evil parrot.

On a side note, I got the angel wings from a site that said they were free (https://www.vecteezy.com/vector-art/154028-free-wings-collection-line-vector), so hopefully that means there won't be any copyright issues.

@melinerunen
Copy link
Collaborator

Hey! can you make based from the HD model? This is going to be a unfar fight if it's not on HD :sadparrot:

@jmhobbs
Copy link
Owner

jmhobbs commented Oct 12, 2017

Looks great! +1 for an HD version, but I can merge this one and we can add HD later.

@trcliao
Copy link
Contributor Author

trcliao commented Oct 13, 2017

Sure, I'll work on an HD version.

@trcliao
Copy link
Contributor Author

trcliao commented Oct 15, 2017

@jmhobbs Should I add the hd angel parrot to the hd folder, get rid of the old angel parrot, and use "hd" instead of "gif" in parrots.json?

@jmhobbs
Copy link
Owner

jmhobbs commented Oct 16, 2017

@trcliao I would keep both versions, some people like the pixelated charm of the small ones. HD one's go in the HD folder and then you have an entry with both fields, like so:

{
    "gif": "angelparrot.gif",
    "hd": "hd/angelparrot.gif",
    "name": "Angel Parrot"
}

Thanks!

@jmhobbs jmhobbs merged commit 1821616 into jmhobbs:master Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants