Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install transformers for executor docker images #851

Merged
merged 6 commits into from
Nov 9, 2022
Merged

Conversation

ZiniuYu
Copy link
Member

@ZiniuYu ZiniuYu commented Nov 9, 2022

This pr installs the missing transformers package for torch & onnx executor docker images in hubble so that users can use M-CLIP models.

It also updates the hubble executor readme.

@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #851 (ab2ffa8) into main (4fcbf68) will decrease coverage by 10.77%.
The diff coverage is n/a.

❗ Current head ab2ffa8 differs from pull request most recent head ff308f0. Consider uploading reports for the commit ff308f0 to get more accurate results

@@             Coverage Diff             @@
##             main     #851       +/-   ##
===========================================
- Coverage   81.39%   70.61%   -10.78%     
===========================================
  Files          21       21               
  Lines        1596     1596               
===========================================
- Hits         1299     1127      -172     
- Misses        297      469      +172     
Flag Coverage Δ
cas 70.61% <ø> (-10.78%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/clip_server/executors/clip_tensorrt.py 0.00% <0.00%> (-93.11%) ⬇️
server/clip_server/model/clip_trt.py 0.00% <0.00%> (-85.72%) ⬇️
server/clip_server/model/trt_utils.py 0.00% <0.00%> (-83.52%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Dockerfiles/cuda.Dockerfile Outdated Show resolved Hide resolved
@ZiniuYu ZiniuYu changed the title fix: install transformers for torch executor docker images fix: install transformers for executor docker images Nov 9, 2022
Copy link
Member

@numb3r3 numb3r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@numb3r3 numb3r3 merged commit f96ce54 into main Nov 9, 2022
@numb3r3 numb3r3 deleted the fix-hub-docker branch November 9, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants