Fix git pull error #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgehrcke
reviewed
Nov 5, 2021
| @@ -195,7 +195,7 @@ do | |||
| # quite likely to succeed. Not sure if more than 1 loop iteration will | |||
| # ever be hit in the real world. | |||
| set -x | |||
| git pull # error out if pull fails (errexit) | |||
| git pull origin "${DATA_BRANCH_NAME}" # error out if pull fails (errexit) | |||
There was a problem hiding this comment.
Hey! Sorry for replying only now. Can you maybe describe in the pull request in which situation this patch is important? Would love to see the original error, too -- for the record. Thank you!
|
This patch solves a bug in case that the data branch did not exist yet, and was created at the top of the script. I'll put the details in an issue for you to link this PR with. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.