jest-worker computeWorkerKey option not always grouping

[kassens]

The cache for making workers of jest-worker sticky to a worker using computeWorkerKey seems to only be set in the callback (code). In this example, even though computeWorkerKey is a function returning a constant, multiple workers are created.

This seems unintended?

const Worker = require('jest-worker').default;

async function main() {
  const myWorker = new Worker(require.resolve('./worker'), {
    computeWorkerKey: (method, ...args) => 'constant',
  });

  const workItems = new Set(['foo', 'bar', 'baz']);

  for (const workItem of workItems) {
    console.log('start', workItem);
    myWorker.transform('/tmp/foo.js').then(res => {
      console.log('done', workItem);
    })
  }

  myWorker.end();
}

main().then(undefined, err => {
  console.log(err);
});

[mjesun]

Nope, you are right! I think @BYK was working on a fix for this a few weeks ago :)

[mjesun]

@BYK will you be able to take a look at this?

[mjesun]

@kassens So @rafeca will take the task as an introductory one for Jest. Sorry about the delay!

[kassens]

I didn't end up using it more, but might have caused some unintended perf regressions somewhere :)

[mjesun]

Well, anyway, it's fixed 🙂 Sorry for the long time to take care of this!

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.