Consolidate Plug Locations

[jherdman]

Move these two plugs with their other friends.

[doomspork]

If we are going to move the files we should update the module names to reflect this change.

[jherdman]

Do you have a recommendation? It appears that other plugs in this directory are named as such:

• JSONAPI.ContentTypeNegotiation
• JSONAPI.EnsureSpec
• JSONAPI.FormatRequired
• JSONAPI.IdRequired

I'm assuming you want something like JSONAPI.Plugs.MyPlug. If this is the case, is it possible to alias module names so as not to break existing code? We could then deprecate the old invocation.

[doomspork]

I was mostly referring to JSONAPI.PlugResponseContentType, the Plug prefix is unnecessary. If we're going to move the files now would be the time to fix module names otherwise there's not much reason to move things around at this time, it's just churn.

I'm assuming you want something like JSONAPI.Plugs.MyPlug.

I personally would for clarity, but I'd like to hear what @jeregrine and @snewcomer think

If this is the case, is it possible to alias module names so as not to break existing code?

I don't think we want to start creating alias for backwards compatibility, maintaining that long term would be a nightmare. It's possible to cut a new release with a new version to signify breaking changes.

[jherdman]

I don't think we want to start creating alias for backwards compatibility, maintaining that long term would be a nightmare. It's possible to cut a new release with a new version to signify breaking changes.

Agreed. It'd be nice to do this if even just to give people a fair heads up (if even until the 1.0 release).

I was mostly referring to JSONAPI.PlugResponseContentType, the Plug prefix is unnecessary...

Fixing!

Edit: I'm going to hold off on this until someone chimes in on backward compatibility.

[jherdman]

@doomspork after some silence on the matter I decided to make the changes you requested.

[jherdman]

@doomspork FYI added a test for this plug too, it was missing one.

[doomspork]

@jherdman sorry! The run up the holidays is hectic around here.