Apply optional dash-to-underscore to include keys #102
Conversation
lib/jsonapi/utils/dash.ex
Outdated
| @@ -0,0 +1,29 @@ | |||
| defmodule JSONAPI.Utils.Dash do | |||
There was a problem hiding this comment.
Does this do more than the existing https://github.com/jeregrine/jsonapi/blob/d4371362ecaadaece27f4d640722f0beae90e6ad/lib/jsonapi/utils/underscore.ex#L1 ?
There was a problem hiding this comment.
It just converts from dash to underscore, where Underscore coverts from underscore to dash. Wasn't sure if I should just add a dash function to the Underscore module or create a separate module. Let me know which approach you prefer and I'll update the PR if needed. :)
There was a problem hiding this comment.
Lets merge this into one module, if you feel better renaming it thats fine just make sure the tests pass. But since they both use the same configuration and both have functionally the same responsibility I think having one will be better.
|
@jeregrine updated, thanks! |
|
@jeregrine Anything else needed for this one? |
|
Thank you for the work on this! Sorry for the delay ❤️ |
When specifying an include string in request which contains dashed entries (e.g.
article.guest-authors) and library is configured to convert dashes to underscoreguest-authorsshould be transformed toguest_authors.Currently, without this an error is thrown caused by converting string to an unknown atom.