From 352759da649dab9bd993a6ea03c096f976405597 Mon Sep 17 00:00:00 2001 From: hp77 Date: Mon, 25 Jan 2021 22:12:51 +0530 Subject: [PATCH 1/2] Add directory address in DirectoryCreationException Message --- .../java/io/jenkins/tools/pluginmanager/impl/PluginManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugin-management-library/src/main/java/io/jenkins/tools/pluginmanager/impl/PluginManager.java b/plugin-management-library/src/main/java/io/jenkins/tools/pluginmanager/impl/PluginManager.java index 142d80fa..7745d20d 100644 --- a/plugin-management-library/src/main/java/io/jenkins/tools/pluginmanager/impl/PluginManager.java +++ b/plugin-management-library/src/main/java/io/jenkins/tools/pluginmanager/impl/PluginManager.java @@ -192,7 +192,7 @@ void createPluginDir(boolean failIfExists) { try { Files.createDirectories(pluginDir.toPath()); } catch (IOException e) { - throw new DirectoryCreationException("Unable to create plugin directory", e); + throw new DirectoryCreationException("Unable to create plugin directory: "+"'"+pluginDir+"', supply a directory with -d ", e); } } From 0ee9149a841bc8572fac53ed55f3e398489a42ee Mon Sep 17 00:00:00 2001 From: hp77 Date: Tue, 26 Jan 2021 13:48:57 +0530 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: Tim Jacomb <21194782+timja@users.noreply.github.com> --- .../java/io/jenkins/tools/pluginmanager/impl/PluginManager.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugin-management-library/src/main/java/io/jenkins/tools/pluginmanager/impl/PluginManager.java b/plugin-management-library/src/main/java/io/jenkins/tools/pluginmanager/impl/PluginManager.java index 7745d20d..09f5f72e 100644 --- a/plugin-management-library/src/main/java/io/jenkins/tools/pluginmanager/impl/PluginManager.java +++ b/plugin-management-library/src/main/java/io/jenkins/tools/pluginmanager/impl/PluginManager.java @@ -192,7 +192,7 @@ void createPluginDir(boolean failIfExists) { try { Files.createDirectories(pluginDir.toPath()); } catch (IOException e) { - throw new DirectoryCreationException("Unable to create plugin directory: "+"'"+pluginDir+"', supply a directory with -d ", e); + throw new DirectoryCreationException(String.format("Unable to create plugin directory: '%s', supply a directory with -d ", pluginDir), e); } }