Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.12.12 incomplete (JAR file not published) #577

Closed
dduportal opened this issue Jul 11, 2023 · 12 comments
Closed

Release 2.12.12 incomplete (JAR file not published) #577

dduportal opened this issue Jul 11, 2023 · 12 comments

Comments

@dduportal
Copy link
Contributor

dduportal commented Jul 11, 2023

Hello there 👋

The last release 2.12.12 does not have a JAR file attachement like previous versions, causing build errors in downstream PR jenkinsci/docker#1667 which relies on downloading the published artefact.

Capture d’écran 2023-07-11 à 08 28 52

It comes from an incomplete release: the GitHub action "Publish" triggered by the release/tag creation failed with the error Unable to resolve action actions/upload-asset, repository not found

Capture d’écran 2023-07-11 à 08 27 47

The action upload-release-asset is archived, which explains why it's failing.

@dduportal
Copy link
Contributor Author

Proposal : I'm gonna open a PR to switch using the gh command line inb the publish process, as there are no certified GitHub action (and using a 3rd party is a bit weird for this )

@dduportal
Copy link
Contributor Author

@MarkEWaite @timja I'm not maintainer here, may I ask you to:

?

@timja
Copy link
Member

timja commented Jul 11, 2023

Upload manually the JAR file (with the proper naming) to the current 2.12.12

I would rather test while we are in context rather than months later 😄

@timja
Copy link
Member

timja commented Jul 11, 2023

@dduportal
Copy link
Contributor Author

Upload manually the JAR file (with the proper naming) to the current 2.12.12

I would rather test while we are in context rather than months later 😄

I don't mind a new release at all (I also aimed at a new 2.12.13 with my PR, but that let a "broken" release in the GitHub release history while the artifactory history has it.

@dduportal
Copy link
Contributor Author

Looks like it worked? https://github.com/jenkinsci/plugin-installation-manager-tool/releases/tag/2.12.13

Yep, victory \o/ I'm closing the issue, I let the maintainers judge of if it is worth uploading the 2.12.12 or not :)

Thanks!

@timja
Copy link
Member

timja commented Jul 11, 2023

not worth it to me it's superseded by the new one

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Jul 11, 2023

I would prefer to upload the 2.12.12 artifact for consistency and am happy to be the maintainer that does it. However, I can't find that artifact on https://repo.jenkins-ci.org . I also can't find the 2.12.13 artifact on repo.jenkins-ci.org .

I see plugin-management-cli in the https://repo.jenkins-ci.org/artifactory/releases/io/jenkins/plugin-management/ but I don't see the jenkins-plugin-manager-x.xx.xx.jar file on repo.

The jenkins-plugin-manager-x.xx.xx.jar Main class has a fully qualified class io.jenkins.tools.pluginmanager.cli.Main yet https://repo.jenkins-ci.org/artifactory/releases/io/jenkins/tools/ shows that there is no directory for pluginmanager under io.jenkins.tools.

Can someone help me with my weak Artifactory search skills?

@dduportal
Copy link
Contributor Author

I would prefer to upload the 2.12.12 artifact for consistency and am happy to be the maintainer that does it. However, I can't find that artifact on https://repo.jenkins-ci.org . I also can't find the 2.12.13 artifact on repo.jenkins-ci.org .

I see plugin-management-cli in the https://repo.jenkins-ci.org/artifactory/releases/io/jenkins/plugin-management/ but I don't see the jenkins-plugin-manager-x.xx.xx.jar file on repo.

The jenkins-plugin-manager-x.xx.xx.jar Main class has a fully qualified class io.jenkins.tools.pluginmanager.cli.Main yet https://repo.jenkins-ci.org/artifactory/releases/io/jenkins/tools/ shows that there is no directory for pluginmanager under io.jenkins.tools.

Can someone help me with my weak Artifactory search skills?

If you look at the release process workflow file (https://github.com/jenkinsci/plugin-installation-manager-tool/blob/c795ccd05c0c48b9dc624eb82511331acbe12fff/.github/workflows/publish-release-artifact.yml) you'll see on the line 32 that it downloads the jar file from JFrog.

As per

, it's the plugin-management-cli artefact.

E.g. from https://repo.jenkins-ci.org/artifactory/releases/io/jenkins/plugin-management/plugin-management-cli/2.12.12/ for this release.

@MarkEWaite is that ok for you?

@MarkEWaite
Copy link
Contributor

MarkEWaite commented Jul 11, 2023

If you look at the release process workflow file (https://github.com/jenkinsci/plugin-installation-manager-tool/blob/c795ccd05c0c48b9dc624eb82511331acbe12fff/.github/workflows/publish-release-artifact.yml) you'll see on the line 32 that it downloads the jar file from JFrog.

As far as I can tell, the jar file that it downloads (https://repo.jenkins-ci.org/artifactory/releases/io/jenkins/plugin-management/plugin-management-cli/2.12.12/plugin-management-cli-2.12.12.jar) is then packaged with an additional Java class and that is used to create the delivered jar file, I am unable to find an archive of the delivered jar file

@dduportal
Copy link
Contributor Author

If you look at the release process workflow file (https://github.com/jenkinsci/plugin-installation-manager-tool/blob/c795ccd05c0c48b9dc624eb82511331acbe12fff/.github/workflows/publish-release-artifact.yml) you'll see on the line 32 that it downloads the jar file from JFrog.

As far as I can tell, the jar file that it downloads (https://repo.jenkins-ci.org/artifactory/releases/io/jenkins/plugin-management/plugin-management-cli/2.12.12/plugin-management-cli-2.12.12.jar) is then packaged with an additional Java class and that is used to create the delivered jar file, I am unable to find an archive of the delivered jar file

The release process "only" uploads (as attachement to the freshly published GitHub release) the file downloaded with wget:

run: gh release upload ${{ steps.set-version.outputs.project-version }} ./${{ steps.fetch-artifact.outputs.file-name }}-${{ steps.set-version.outputs.project-version }}.jar

@MarkEWaite
Copy link
Contributor

Thanks for the explanation. Now I understand. The plugin-management-cli-2.12.12.jar downloaded from repo is renamed to jenkins-plugin-manager-2.12.12.jar and uploaded to GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants