Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete plugin selection modes other than -war #388

Closed
jglick opened this issue Dec 1, 2022 · 1 comment · Fixed by #419
Closed

Delete plugin selection modes other than -war #388

jglick opened this issue Dec 1, 2022 · 1 comment · Fixed by #419

Comments

@jglick
Copy link
Member

jglick commented Dec 1, 2022

jenkinsci/bom and @cloudbees both run PCT using the -war option. To simplify the code base, we should delete all other run modes—checking the update center (including both explicit -updateCenterUrl and the default UC), -parentCoordinates (whatever that does), -bom (#202), probably -overridenPlugins [sic] (#88).

As of this writing, bom uses

  • -war
  • -includePlugins
  • -workDirectory
  • -reportFile
  • -m2SettingsFile
  • -mavenProperties
  • -excludeHooks org.jenkins.tools.test.hook.TransformPom (see Delete TransformPom #387)
  • -mavenPropertiesFile
  • -skipTestCache

CloudBees also uses

  • -storeAll
  • -fallbackGitHubOrganization
  • -mvn
  • -hookPrefixes
  • -externalHooksJars
  • -testJDKHome
  • -localCheckoutDir
  • -includePlugins

CC @jtnord
@basil
Copy link
Member

basil commented Dec 2, 2022

https://en.wikipedia.org/wiki/Flensing

@basil basil mentioned this issue Jan 28, 2023
Merged
@basil basil closed this as completed in #419 Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Delete plugin selection modes other than -war jenkinsci/plugin-compat-tester
2 participants
@basil @jglick