From 708d7aaa7c5c234af4f8e2e951a76a1439f7fd88 Mon Sep 17 00:00:00 2001 From: "Brinkop Andre (uib05464)" Date: Tue, 18 Jul 2023 14:02:48 +0200 Subject: [PATCH] Fix permission type in checkAgentUserPermission function --- .../plugins/GithubRequireOrganizationMembershipACL.java | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/main/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACL.java b/src/main/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACL.java index 4659c4a0..a7c8d81d 100644 --- a/src/main/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACL.java +++ b/src/main/java/org/jenkinsci/plugins/GithubRequireOrganizationMembershipACL.java @@ -250,11 +250,10 @@ private boolean checkReadPermission(@NonNull Permission permission) { } private boolean checkAgentUserPermission(@NonNull Permission permission) { - String id = permission.getId(); - return (id.equals(Hudson.READ) - || id.equals(Computer.CREATE) - || id.equals(Computer.CONNECT) - || id.equals(Computer.CONFIGURE)); + return permission.equals(Hudson.READ) + || permission.equals(Computer.CREATE) + || permission.equals(Computer.CONNECT) + || permission.equals(Computer.CONFIGURE); } private boolean checkJobStatusPermission(@NonNull Permission permission) {