Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a password to the Digicert signing certificate #362

Closed
dduportal opened this issue Apr 6, 2023 · 2 comments
Closed

Add a password to the Digicert signing certificate #362

dduportal opened this issue Apr 6, 2023 · 2 comments
Labels

Comments

@dduportal
Copy link
Contributor

As per

*.pfx)
# pfx file download from azure key vault are not password protected, which is required for maven release plugin
# so we need to add a new password
, the pfx file does not have a password.

However, this comment was made in 2020. We are 2023, and as per https://learn.microsoft.com/en-us/azure/key-vault/certificates/tutorial-import-certificate?tabs=azure-portal, password for pfxcertificate seems supported.

As an additional layer of security, we should be able to use a password (instead of converting pfx to pem for adding one).

Discovered while working on jenkins-infra/helpdesk#3323

@timja
Copy link
Member

timja commented Apr 6, 2023

You might want to read the docs a bit closer ^.^

Once the certificate file is successfully imported, key vault will remove that password.

@dduportal
Copy link
Contributor Author

🤦 correct, thanks for pointing it out 😅

Gotta close the issue then 👍

@dduportal dduportal closed this as not planned Won't fix, can't repro, duplicate, stale Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants