Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong index in libraryoptionseditor.js #1234

Closed
Kaduo opened this issue May 15, 2020 · 1 comment
Closed

Wrong index in libraryoptionseditor.js #1234

Kaduo opened this issue May 15, 2020 · 1 comment
Labels
bug Something isn't working confirmed The issue has been verified good first issue Good for newcomers

Comments

@Kaduo
Copy link

Kaduo commented May 15, 2020

In src/components/libraryoptionseditor/libraryoptionseditor.js, a variable "i" is referenced on line 123 but should be renamed to "index" for the code to make sense. I'd fix it myself if I had access to my setup, but I don't so I figured I'd create an issue. Here is the relevant code:

//Line 113:
plugins.array.forEach((plugin, index) => {
    //[...]
    //Line 123:
    i > 0 ? html += '<button type="button" is="paper-icon-button-light" title="' + globalize.translate('ButtonUp') + '" class="btnSortableMoveUp btnSortable" data-pluginindex="' + i + '"><span class="material-icons keyboard_arrow_up"></span></button>' : plugins.length > 1 && (html += '<button type="button" is="paper-icon-button-light" title="' + globalize.translate('ButtonDown') + '" class="btnSortableMoveDown btnSortable" data-pluginindex="' + i + '"><span class="material-icons keyboard_arrow_down"></span></button>'), html += '</div>';
    });
@anthonylavado anthonylavado added bug Something isn't working confirmed The issue has been verified good first issue Good for newcomers labels May 16, 2020
@sarab97
Copy link
Contributor

sarab97 commented May 18, 2020

i see this is resolved already in #1084

@dkanada dkanada closed this as completed May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed The issue has been verified good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants