Fix Absolute permalinks break paginator when permalink is specified for index file #5 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| page | ||
| end | ||
| def source_to_file_path(page) | ||
| page.url_placeholders[:path] # meant to use page.instance_variable_get('@dir') |
There was a problem hiding this comment.
Tried with page.path but test was failed since this includes filename.
File.dirname(page.path) seems to be another solution clearer than page.url_placeholders[:path]
There was a problem hiding this comment.
Try page.relative_path then 😄 There was a liquid inconsistency that this will bump into.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues related to absolute permalink in index file.
Since this is my first commit to a open-source project, let me know anything I have missed or can improve.
Thanks.