Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix encoding of space characters in URI #254

Closed
charphi opened this issue Mar 20, 2024 · 3 comments · Fixed by #255
Closed

Fix encoding of space characters in URI #254

charphi opened this issue Mar 20, 2024 · 3 comments · Fixed by #255
Assignees
Labels
bug Something isn't working
Milestone

Comments

@charphi
Copy link
Contributor

charphi commented Mar 20, 2024

Current implementation of URI formatting in DataSource and DataSet encodes space characters as + instead of %20.
This comes from backward compatibility in Java URLEncoder.

More info:

@charphi charphi added the bug Something isn't working label Mar 20, 2024
@charphi charphi linked a pull request Mar 21, 2024 that will close this issue
@charphi charphi added this to the 3.2.3 milestone Jun 4, 2024
@charphi charphi self-assigned this Jun 5, 2024
@TanguyBarthelemy
Copy link

Is this resolved? I just tested the SNAPSHOT of the v3.2.3 and I still get some + in the path:
image

@charphi
Copy link
Contributor Author

charphi commented Jun 10, 2024

I don't have the problem. Try do create a new workspace from scratch. Maybe it is just old URI from previous version.

@TanguyBarthelemy
Copy link

I downloaded the latest snapshot from this morning and now it works!
Maybe I tested with a too old snapshot...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants