Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MkQuery should have method to return body bytes #113

Closed
krzyk opened this issue Sep 27, 2015 · 13 comments
Closed

MkQuery should have method to return body bytes #113

krzyk opened this issue Sep 27, 2015 · 13 comments

Comments

@krzyk
Copy link

krzyk commented Sep 27, 2015

To retrieve String body using MkQuery one can use body() method, but there is no method to retrieve binary data, so it is impossible to test handling of non-text content.
Please add a method that would return byte[] of the body, without any transcoding.

@longtimeago
Copy link
Contributor

@yegor256 can we dispatch the issue?

@dmarkov
Copy link

dmarkov commented Sep 30, 2015

@krzyk we will find someone to do this task, soon

@dmarkov
Copy link

dmarkov commented Sep 30, 2015

@krzyk thanks for the report, I topped your acc for 15 mins, payment ID 66328266

@longtimeago
Copy link
Contributor

@dmarkov please, give it to me. I have a fix

@longtimeago
Copy link
Contributor

@dmarkov here is the fix #114

@yegor256
Copy link
Member

yegor256 commented Oct 3, 2015

@rultor release, tag is 1.13

@rultor
Copy link
Contributor

rultor commented Oct 3, 2015

@rultor release, tag is 1.13

@yegor256 OK, I will release it now. Please check the progress here

@rultor
Copy link
Contributor

rultor commented Oct 3, 2015

@rultor release, tag is 1.13

@yegor256 Done! FYI, the full log is here (took me 5min)

@longtimeago
Copy link
Contributor

@yegor256 cool, thanks!

@longtimeago
Copy link
Contributor

@krzyk please, close the issue

@krzyk
Copy link
Author

krzyk commented Oct 3, 2015

@longtimeago great, thanks

@krzyk krzyk closed this as completed Oct 3, 2015
@dmarkov
Copy link

dmarkov commented Oct 5, 2015

@dmarkov please, give it to me. I have a fix

@longtimeago @yegor256 any objections?

@dmarkov
Copy link

dmarkov commented Oct 5, 2015

@dmarkov here is the fix #114

@longtimeago OK thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants