Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArC - stack log messages about usage of private members #862

Merged
merged 1 commit into from
Feb 12, 2019
Merged

ArC - stack log messages about usage of private members #862

merged 1 commit into from
Feb 12, 2019

Conversation

mkouba
Copy link
Contributor

@mkouba mkouba commented Feb 12, 2019

Before:

[INFO] [org.jboss.protean.arc.processor.BeanGenerator] PreDestroy callback org.acme.events.AppLifecycleBean#destroy is private - users are encouraged to avoid using private callbacks
[INFO] [org.jboss.protean.arc.processor.BeanGenerator] Constructor org.acme.events.AppLifecycleBean is private - users are encouraged to avoid using private constructors
[INFO] [org.jboss.protean.arc.processor.BeanGenerator] @Inject org.acme.events.AppLifecycleBean#config is private - users are encouraged to avoid using private injection fields
[INFO] [org.jboss.protean.arc.processor.BeanGenerator] @Inject org.acme.events.AppLifecycleBean#config2 is private - users are encouraged to avoid using private injection fields
[INFO] [org.jboss.protean.arc.processor.BeanGenerator] @Inject org.acme.events.AppLifecycleBean#config3 is private - users are encouraged to avoid using private injection fields
[INFO] [org.jboss.protean.arc.processor.BeanGenerator] @Inject org.acme.events.AppLifecycleBean#config4 is private - users are encouraged to avoid using private injection fields
[INFO] [org.jboss.protean.arc.processor.ObserverGenerator] Observer org.acme.events.AppLifecycleBean#onStop is private - users are encouraged to avoid using private observers

After:

[INFO] [org.jboss.protean.arc.processor.BeanProcessor] Found unrecommended usage of private members in application beans:
	- @PreDestroy callback org.acme.events.AppLifecycleBean#destroy(),
	- Bean constructor void <init>() on org.acme.events.AppLifecycleBean,
	- @Inject field org.acme.events.AppLifecycleBean#config
	- and 4 more - please enable debug logging to see the full list

And (if DEBUG is enabled):

[INFO] [org.jboss.protean.arc.processor.BeanProcessor] Found unrecommended usage of private members in application beans:
	- @PreDestroy callback org.acme.events.AppLifecycleBean#destroy(),
	- Bean constructor void <init>() on org.acme.events.AppLifecycleBean,
	- @Inject field org.acme.events.AppLifecycleBean#config,
	- @Inject field org.acme.events.AppLifecycleBean#config2,
	- @Inject field org.acme.events.AppLifecycleBean#config3,
	- @Inject field org.acme.events.AppLifecycleBean#config4,
	- Observer method org.acme.events.AppLifecycleBean#onStop()

@Sanne
Copy link
Member

Sanne commented Feb 12, 2019

nice, thanks!

@Sanne Sanne merged commit 2398151 into quarkusio:master Feb 12, 2019
@Sanne Sanne deleted the issue-855-private-members branch February 12, 2019 22:15
@stuartwdouglas stuartwdouglas added this to the 0.9.0 milestone Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sanne Sanne Sanne approved these changes

@stuartwdouglas stuartwdouglas Awaiting requested review from stuartwdouglas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.

ArC - stack log messages about usage of private members
3 participants
@mkouba @Sanne @stuartwdouglas