Rename standard jar when uberJar option is used #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When uberJar is specified we rename the standard jar by adding the .original suffix. This is done in order to help tools that expect a single jar in the output directory to work out of the box (one such case is Openshift s2i)
geoand
force-pushed
the
uberjar-names
branch
from
5ed882f
to
d06fd24
Compare
stuartwdouglas
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
uberJaris specified we rename the standard jar by adding the.originalsuffix.This is done in order to help tools that expect a single jar in the
output directory to work out of the box (a prominent case being Openshift S2I)