REST client with native and SSL #806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmlloyd
reviewed
Feb 8, 2019
| final Enumeration<URL> resources = classLoader.getResources(fileName); | ||
| final Set<Class<?>> found = new HashSet<>(); | ||
|
|
||
| final Set<String> classNames = new HashSet<>(); |
There was a problem hiding this comment.
This should either be a LinkedHashSet (preferred) or a TreeSet. Otherwise the build results could vary from build to build based on HashSet's capacity and hashing algorithm of the day.
| @@ -29,17 +39,23 @@ private ServiceUtil() {} | |||
| try (BufferedReader br = new BufferedReader(isr)) { | |||
| String line; | |||
| while ((line = br.readLine()) != null) { | |||
| if (line.contains("#")) { | |||
There was a problem hiding this comment.
If we're changing this anyway... using indexOf here and checking for -1 would mean the string is only traversed one time. Obviously not a big deal though.
There was a problem hiding this comment.
while at it .. Prefer indexOf('#') over indexOf("'#") :)
There was a problem hiding this comment.
Yeah, to be honest, I just centralized the best implementation we had without thinking twice about it.
I’ll improve it first thing tomorrow.
ServiceUtil was very naive, not filtering empty lines and not taking into account comments. I moved the best implementation of that we had in the code base to ServiceUtil and it is now used consistently. Returning a Set as more flexible than an Iterable.
It initializes some stuff we don't want to initialize in the native image.
It's not the correct solution and we will fix that later but let's not invest too much time in it as the SmallRye REST client is coming.
This extension is not designed to be used externally and will probably go away once we migrate the REST client part to the reactive client. It will then be incorporated again in the RESTEasy (server) extension.
Sanne
approved these changes
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just wanted to write the SSL guide and thought the REST client quickstart would be nice to base this guide on.
Unfortunately, it was a rabbit hole.
This PR changes a few various things:
ServiceUtila bit as I needed it, @dmlloyd could you take a look at this particular commit: ba3f1be ?Best reviewed commit per commit as they are not directly related even if they have the same goal: being able to use the REST client extension in native mode to access SSL services.
Hopefully, once we have moved to the SmallRye REST client, we will work a bit more on it to better optimize it.