Remove dependency on SVM class #747
Conversation
|
Also see: quarkusio/quarkus-quickstarts#34 |
geoand
force-pushed
the
restclient-svm-exception
branch
from
28f0692
to
11faf92
Compare
| throw new IllegalArgumentException(baseUrl + " requires SSL support but it is disabled. You probably have set shamrock.ssl.native to false."); | ||
| } catch (Exception e) { | ||
| if ("com.oracle.svm.core.jdk.UnsupportedFeatureError".equals(e.getClass().getCanonicalName())) { | ||
| throw new IllegalArgumentException(baseUrl + " requires SSL support but it is disabled. You probably have set shamrock.ssl.native to false."); |
There was a problem hiding this comment.
Good catch. By the way, could you also fix it to not swallow the original exception and add it as a cause?
Thanks.
There was a problem hiding this comment.
Sure thing, I will do that!
There was a problem hiding this comment.
Done. Although CI seemed to be failing for some reason (I did a build locally and everything was OK - I didn't try native however)
There was a problem hiding this comment.
I also ran the native test this time locally and everything seemed fine
|
Can someone please post the CI output? I don't have access to it. |
|
Hum. Apparently, when you have a cause, it's automatically unwrapped (at least in the case we have here). Thus the original error message is gone and the test checking the message fails. So let's remove the cause for now and if you could squash everything and rebase, that would be perfect. Thanks! |
This dependency caused: java.lang.ClassNotFoundException: com.oracle.svm.core.jdk.UnsupportedFeatureError when using the RestClient in HotSpot mode
geoand
force-pushed
the
restclient-svm-exception
branch
from
a310ff9
to
54b5cf3
Compare
|
@gsmet PR rebased with the cause removed |
|
Thanks. Sorry about the noise, I didn't expect this unwrapping. Will merge once CI is clear. |
|
@gsmet No reason to be sorry :) |
|
Thanks! |
Was originally tested in an unclean test environment which hid the problem of performing a zero-install run on Windows when using Cygwin/GitBash/etc Fixes quarkusio#746
This dependency caused:
java.lang.ClassNotFoundException: com.oracle.svm.core.jdk.UnsupportedFeatureErrorwhen using the RestClient in HotSpot mode