Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully stop rather than hang when there are no steps #680

Merged
merged 1 commit into from
Jan 30, 2019
Merged

Gracefully stop rather than hang when there are no steps #680

merged 1 commit into from
Jan 30, 2019

Conversation

FroMage
Copy link
Member

@FroMage FroMage commented Jan 30, 2019

Otherwise the runner just hangs waiting for steps. Admittedly that only happens when the APT processor failed to create the appropriate build steps, but it happens.

@FroMage FroMage added the kind/bug Something isn't working label Jan 30, 2019
dmlloyd
dmlloyd approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@dmlloyd dmlloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just thinking about this problem yesterday. :) Thanks for reading my mind!

@FroMage FroMage merged commit 5d0b705 into quarkusio:master Jan 30, 2019
@FroMage
Copy link
Member Author

FroMage commented Jan 30, 2019

OK thanks, merged then.

@cescoffier cescoffier added this to the 0.8.0 milestone Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmlloyd dmlloyd dmlloyd approved these changes

@stuartwdouglas stuartwdouglas Awaiting requested review from stuartwdouglas

Assignees
No one assigned
Labels
kind/bug Something isn't working
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
3 participants
@FroMage @dmlloyd @cescoffier