ArC - document "remove unused beans" optimization #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsmet
reviewed
Jan 30, 2019
| @@ -168,6 +170,8 @@ List<AdditionalBeanBuildItem> additionalBeans() { | |||
| } | |||
| ---- | |||
|
|
|||
| NOTE: An bean registration that is a result of an `AdditionalBeanBuildItem` is removable by default. See also <<remove_unused_beans>>. | |||
|
|
||
| The container attempts to remove all unused beans during build by default. | ||
| This optimization could be disabled: `shamrock.arc.remove-unused-beans=false`. |
| default <T> T instance(Class<T> type, Annotation... qualifiers) { | ||
| return instanceFactory(type, qualifiers).get(); | ||
| return instanceFactory(type, qualifiers).get(); |
...ent-projects/arc/processor/src/main/java/org/jboss/protean/arc/processor/BeanDeployment.java
Show resolved
Hide resolved
|
LGTM! |
mkouba
force-pushed
the
log-unused-beans-removal
branch
from
cfd521f
to
883cf4c
Compare
gsmet
approved these changes
Jan 30, 2019
| @@ -137,6 +137,8 @@ BeanDefiningAnnotationBuildItem additionalBeanDefiningAnnotation() { | |||
| } | |||
| ---- | |||
|
|
|||
| NOTE: Bean registrations that are result of an `BeanDefiningAnnotationBuildItem` are unremovable by default. See also <<remove_unused_beans>>. | |||
There was a problem hiding this comment.
sorry missed this one first: s/of an/of a/
There was a problem hiding this comment.
No need to sorry for my error ;-). Thanks!
- log a warning message when an extension template attempts to use a removed bean - resolves #658
mkouba
force-pushed
the
log-unused-beans-removal
branch
from
883cf4c
to
ca97498
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
removed bean
NOTE: This is just the first attempt to address #658 and improve the UX.