Create a JUnit 5 Internal module and post ShamrockUnitTest for our in… #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartwdouglas
force-pushed
the
shamrock-unit-test-junit5
branch
10 times, most recently
from
1c560d3
to
42e68d5
Compare
mkouba
reviewed
Jan 21, 2019
...s/arc/deployment/src/main/java/org/jboss/shamrock/arc/deployment/ArcAnnotationProcessor.java
Outdated
Show resolved
Hide resolved
gsmet
reviewed
Jan 21, 2019
| import static org.junit.Assert.assertEquals; | ||
| import static org.junit.Assert.assertTrue; | ||
| import static org.junit.jupiter.api.Assertions.assertEquals; | ||
| import static org.wildfly.common.Assert.assertTrue; |
| @@ -114,6 +115,15 @@ public void handleRequest(HttpServerExchange exchange) throws Exception { | |||
| return new RuntimeValue<>(d); | |||
| } | |||
|
|
|||
| public static SocketAddress getHttpAddress() { | |||
| for (Undertow.ListenerInfo info : undertow.getListenerInfo()) { | |||
| if (info.getProtcol().equals("http") && info.getSslContext() == null) { | |||
There was a problem hiding this comment.
Not related to this patch but there's a typo here: s/getProtcol()/getProtocol()/
integration-tests/jpa-h2/src/test/java/org/jboss/shamrock/example/test/TestResources.java
Show resolved
Hide resolved
There are now three different runners: - junit5: our preferred runner for end users - junit4: legacy runner for JUnit 4 - junit5-internal: unit test runner for testing Shamrock itself
stuartwdouglas
force-pushed
the
shamrock-unit-test-junit5
branch
from
42e68d5
to
cbd69ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ternal testing purposes
This moves our internal Shrinkwrap based tests to JUnit 5