Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip shamrock:dev on projects that do not have the build goal configured #561

Merged
merged 1 commit into from
Jan 19, 2019

Conversation

stuartwdouglas
Copy link
Member

This allows Shamrock to work in multi-module project, the dev goal will only
be run for the actual shamrock app, not parent poms or support libraries.


boolean found = false;
for(Plugin i : project.getBuildPlugins()) {
if(i.getGroupId().equals("org.jboss.shamrock") && i.getArtifactId().equals("shamrock-maven-plugin")) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be reasonable to use some shared constants here... for groupId, plugin name, etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me take over this task. I need to fix the different variable format and will inject the "right" groupId and artifactId (coming from Maven filtering and not constants).

…oal configured

This allows Shamrock to work in multi-module project, the dev goal will only
be run for the actual shamrock app, not parent poms or support libraries.
@cescoffier
Copy link
Member

Merging, as I provide my improvements in a separated PR as it's not only about this task.

@cescoffier cescoffier merged commit 284f33f into quarkusio:master Jan 19, 2019
@cescoffier cescoffier added this to the 0.7.0 milestone Jan 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants