Add support for injection into ShamrockTest and remove the need for RuntimeClassLoader #1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aloubyansky I am not sure how this will impact your work, it might be best to hold off until your stuff is in |
stuartwdouglas
force-pushed
the
test-injection-2
branch
from
71b97de
to
e15094e
Compare
stuartwdouglas
force-pushed
the
test-injection-2
branch
from
e15094e
to
8680597
Compare
dmlloyd
reviewed
Feb 28, 2019
| @@ -143,7 +143,7 @@ NOTE: Bean registrations that are result of a `BeanDefiningAnnotationBuildItem` | |||
|
|
|||
| `ResourceAnnotationBuildItem` is used to specify resource annotations that make it possible to resolve non-CDI injection points, such as Java EE resources. | |||
|
|
|||
| NOTE: An integrator must also provide a corresponding `io.quarkus.arc.ResourceReferenceProvider` implementation. | |||
| NOTE: An integrator must also provide a corresponding `io.quarkus.arc.ResourceReferenceProvider` implementation. | |||
There was a problem hiding this comment.
Looks like a whitespace change?
There was a problem hiding this comment.
I don't know why, that that whitespace is the one thing that gets messed up if you follow the rename process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.