Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Next steps for configuration #705

Closed
3 tasks done
dmlloyd opened this issue Feb 1, 2019 · 2 comments
Closed
3 tasks done

Next steps for configuration #705

dmlloyd opened this issue Feb 1, 2019 · 2 comments
Assignees
Milestone

Comments

@dmlloyd
Copy link
Member

dmlloyd commented Feb 1, 2019

The next step for configuration is to make the config groups with @ConfigRoot annotations be authoritative roots for configuration. This entails a few steps:

  • Update ExtensionAnnotationProcessor to list config root classes similarly to how build step classes are currently done
  • Create a build step to consume this file and produce build items
  • Create a build step to consume the config root class build items and register them into the configuration tree (taking over this job from ExtensionStepLoader and possibly partially from ConfigSetup)
@dmlloyd dmlloyd self-assigned this Feb 1, 2019
@dmlloyd
Copy link
Member Author

dmlloyd commented Feb 2, 2019

Configuration root classes should be allowed to end in Config, which would be stripped off automatically (unless it is the whole name). This is because the class name is likely to conflict with the thing it is configuring otherwise.

Maybe we should allow a suffix for fields too, that gets automatically stripped, since e.g. class would be a pretty common key.

@emmanuelbernard
Copy link
Member

Is that a first public release for some of these steps? If so let's label it.

gsmet added a commit that referenced this issue Feb 6, 2019
@dmlloyd dmlloyd added this to the 0.8.0 milestone Feb 6, 2019
@dmlloyd dmlloyd closed this as completed Feb 6, 2019
maxandersen pushed a commit to maxandersen/quarkus that referenced this issue Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants