Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify version properties names in build-parent #280

Closed
mkouba opened this issue Dec 13, 2018 · 7 comments
Closed

Unify version properties names in build-parent #280

mkouba opened this issue Dec 13, 2018 · 7 comments
Milestone

Comments

@mkouba
Copy link
Contributor

mkouba commented Dec 13, 2018

This follows up issue #275. I think we should use something like version.foo-name, e.g. version.jandex or version.opentracing-jaxrs.

@cescoffier
Copy link
Member

While I don't have a strong opinion, the general convention is: artifactId.version
(example: https://www.mojohaus.org/versions-maven-plugin/examples/update-properties.html)

I believe the reason is purely a developer experience thingy. When you import the dependency, you know the artifactId, so the autocompletion narrows the number of choices. If you just start typing ver you get a large bunch of possibilities.

@cescoffier
Copy link
Member

cescoffier commented Dec 14, 2018

important: this impact the release scripts.

@stuartwdouglas
Copy link
Member

I think this has been fixed now?

@gsmet
Copy link
Member

gsmet commented Jan 8, 2019

No, we still have version.org.jandex that is different from the others. It follows the WildFly convention.

If we decide to go with the jandex.version convention, we just have to fix this one. If we decide to go with the WildFly convention, we have to change all the others.

Personally, I don't care, let's just decide and be consistent. Just changing the Jandex one is obviously the easy path.

@mkouba
Copy link
Contributor Author

mkouba commented Jan 8, 2019

Well, I personally prefer the version.artifact pattern because it's immediately clear that a property represents a version. WRT autocompletion - I don't think this is really helpful. Anyway, tools like dependabot do support both patterns.

Also note that artifactId is not always enough as it is not unique. So you may end up with more complex properties.

@gsmet
Copy link
Member

gsmet commented Jan 8, 2019

FWIW, WildFly, is more version.<groupId> (most of the time).

@stuartwdouglas
Copy link
Member

This seems to be resolved now

@cescoffier cescoffier added this to the 0.7.0 milestone Jan 21, 2019
maxandersen added a commit to maxandersen/quarkus that referenced this issue Nov 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants