Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect --find-links in requirements.in and put it in compiled requirements.txt #591

Closed
wooyek opened this issue Oct 30, 2017 · 2 comments
Closed

Comments

@wooyek
Copy link

wooyek commented Oct 30, 2017

I have had --find-links=requirements in requirements.txt. It point's to a folder containing proprietary libraries, this folder is deployed alongside the application to CI server, to Heroku, etc.

When I switched to requirements.in and pip-tools, my compiled requirements.txt does not contain it anymore. I know I can supply find-links switch in other ways in target environment, but leaving it in the requirements.txt file is the most simple and robust solution — no need to configure each and every environment separately.

It would be good to somehow whitelist or otherwise put --find-links=requirements in compiled `requirements.txt.

@suutari
Copy link
Contributor

suutari commented Oct 31, 2017

This is already implemented in PR #453, but it's still unmerged.

@wooyek
Copy link
Author

wooyek commented Oct 31, 2017

Sweet :)

@wooyek wooyek closed this as completed Oct 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants