-
-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pip-compile] Cannot disable pip version check #1543
Comments
At first look, I think this is happening behind a call to Utimately, we get here in the def build(source_dir='.', dest=None, system=None):
system = system or load_system(source_dir)
dest = os.path.join(source_dir, dest or 'dist')
mkdir_p(dest)
validate_system(system)
hooks = Pep517HookCaller(
source_dir, system['build-backend'], system.get('backend-path')
)
with hooks.subprocess_runner(quiet_subprocess_runner):
with BuildEnvironment() as env:
env.pip_install(system['requires'])
_prep_meta(hooks, env, dest) And down there at def pip_install(self, reqs):
"""Install dependencies into this env by calling pip in a subprocess"""
if not reqs:
return
log.info('Calling pip to install %s', reqs)
cmd = [
sys.executable, '-m', 'pip', 'install', '--ignore-installed',
'--prefix', self.path] + list(reqs)
check_call(
cmd,
stdout=LoggerWrapper(log, logging.INFO),
stderr=LoggerWrapper(log, logging.ERROR),
) I don't see an obvious way to carry the arguments through this code path, and I'm not sure it's what we want. If you think this is specifically about the warning, maybe https://github.com/pypa/pep517 would accept a change to prevent it. If we really do want to modify this |
|
Isn't it |
@Jorricks This is hitting the code paths in my previous comment, which are outside of pip-tools, where we cannot directly control the arguments passed to those It might be possible to check for that argument, and then set |
I'm inclined to close this, with the best solution for "deep" setting of this option being to set the environment variable. Unless there are objections, I'll close this one soon. Thanks! |
That particular code path (in I am going to close this now, but please write back if I'm making a mistake. Thanks! |
Environment Versions
Python 3.8.10
pip 21.3
pip-compile, version 6.4.0
Steps to replicate
21.3
, while21.3.1
is released)content of setup.py (anything would do I believe)
pip-compile --verbose --pip-args "--disable-pip-version-check" old_package/setup.py
Expected result
There should not be the version check for pip (see full output in actual result)
Actual result
During the isolated build phase,
pip
checks its version.The text was updated successfully, but these errors were encountered: