Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the testing of the linux sysfs parsing code #201

Closed
ffromani opened this issue Dec 3, 2020 · 2 comments
Closed

Improve the testing of the linux sysfs parsing code #201

ffromani opened this issue Dec 3, 2020 · 2 comments
Assignees

Comments

@ffromani
Copy link
Collaborator

ffromani commented Dec 3, 2020

Hi all!

Under linux ghw reads sysfs files/directory to extract informations. I think the tests of this code could be enhanced a bit, but to do so we need to somehow fake sysfs. Would that be a welcome change?

I can think of few way to do this but first I'd love to hear from the maintainers/community if there is a preferred way and/or some past discussion about this topic. Please share any reference (still looking into past issues/PRs, but I may have missed something!)

Thanks!

@ffromani
Copy link
Collaborator Author

ffromani commented Dec 3, 2020

Example approach: #66

@ffromani
Copy link
Collaborator Author

ffromani commented Dec 17, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants