Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub check for "failures all known" #78

Open
jkoritzinsky opened this issue Nov 5, 2020 · 1 comment
Open

GitHub check for "failures all known" #78

jkoritzinsky opened this issue Nov 5, 2020 · 1 comment

Comments

@jkoritzinsky
Copy link

A few times in CI Council we've discussed how we enforce that developers reference the tracking issues for failing tests.

One possible way to enforce this would be to hook into the runfo triage issues and produce a GitHub Check on PRs to track the failing tests. The check would be green there were no failures or if every job (for Timeline queries) or test (for Test, Helix Log, etc. queries) that failed matched an open triage issue. Otherwise, the check would be red. This would enable better tracking for ensuring that PRs correctly reference why there are failing tests before merging on red.

@jkoritzinsky jkoritzinsky changed the title GitHub check for failures all known GitHub check for "failures all known" Nov 5, 2020
@jaredpar
Copy link
Owner

jaredpar commented Nov 5, 2020

I've had similar thoughts. I do think whatever system we decide on for tracking test failures is going to have a behavior similar to this. Probably the simplest approach to start with is a bot that just opens a comment box detailing the failures which are known / not known.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants