Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with maven central #627

Closed
titusthefox04 opened this issue May 8, 2018 · 17 comments
Closed

Problem with maven central #627

titusthefox04 opened this issue May 8, 2018 · 17 comments
Assignees
Labels
enhancement New feature or request project
Milestone

Comments

@titusthefox04
Copy link

String ${packaging.type} not resolved create problem in maven central and in sbt project.

jax-ws-problem2

jax-ws-problem

@chkal
Copy link
Contributor

chkal commented May 9, 2018

This is a duplicate of #572 and #571.

I think this is actually a sbt bug. Maven (and Gradle?) can handle this dynamic packaging type correctly.

@mkarg
Copy link
Contributor

mkarg commented May 11, 2018

@spericas Do you know why we don't simply use <packaging>jar</packaging> instead?

@chkal
Copy link
Contributor

chkal commented May 11, 2018

@mkarg
Copy link
Contributor

mkarg commented May 11, 2018

Looks like this was done solely to make the OSGi packager (bnd) work as it is so outdated that it cannot handle JDK 9. I don't like that solution. OSGi is not part of neither Jakarta EE nor JAX-RS. I'd rather kick OSGi out right now. But what do others think?

@chkal
Copy link
Contributor

chkal commented May 13, 2018

Looks like this was done solely to make the OSGi packager (bnd) work as it is so outdated that it cannot handle JDK 9.

Yeah, looks like this was the reason for introducing the dynamic packing type.

I don't like that solution. OSGi is not part of neither Jakarta EE nor JAX-RS. I'd rather kick OSGi out right now. But what do others think?

AFAIK the OSGi manifests are required for the Glassfish integration. But I'm not familiar with the details.

I think we should keep the OSGi manifest. It doesn't do any harm and OSGi is still quite popular. Maybe bnd even supports Java 9 today? Perhaps fixing this would simply be a matter of updating the maven-bundle-plugin?

@mkarg mkarg self-assigned this May 13, 2018
@mkarg mkarg added the enhancement New feature or request label May 13, 2018
@mkarg mkarg added this to the 2.2 milestone May 13, 2018
@mkarg mkarg added the project label May 13, 2018
@mkarg
Copy link
Contributor

mkarg commented May 13, 2018

At least on my development machine maven-bundle-plugin had no problem to process packaging type bundle on JDK 9+ without special handling of module-info, so I opened PR #628 as a potential solution for this issue.

@spericas
Copy link
Contributor

@mkarg Must have been OSGi. I don't have a problem fixing it to jar.

@mkarg mkarg closed this as completed Jun 15, 2018
@kwhat
Copy link

kwhat commented Sep 26, 2018

So, when is 2.2 being released so I can stop dealing with this problem.

@mkarg
Copy link
Contributor

mkarg commented Sep 26, 2018

I am sorry to say there is no fixed deadline for 2.2, as this depends on ongoing negotiations between Oracle and the Eclipse Foundation.

@spericas @chkal Do you think it would be safe to merge #628 also into EE4J_8?

@spericas
Copy link
Contributor

@mkarg We had to provide a pretty detailed explanation of all the changes that went into EE4J_8 for 2.1.1. I'd rather not check more changes into that branch.

@mkarg
Copy link
Contributor

mkarg commented Sep 26, 2018

@spericas Understood. As I was not involved in that part of the release so dumb question: Did you have to manually write a report or how was this step performed?

@chkal
Copy link
Contributor

chkal commented Sep 27, 2018

I'm basically +1 for including this in the EE4J_8 branch. Especially because the issue affects many users and the fix is actually trivial. Maybe we could draft the explanation of the changes in the wiki or in the git repo so we can work on it together? Maybe having the draft in the git repo is actually a good way to go, because this way we can provide the explanation/changelog within the corresponding pull request!?!

@spericas
Copy link
Contributor

@mkarg It was a manual process. Nothing it could not be done again, of course.

@mkarg
Copy link
Contributor

mkarg commented Sep 27, 2018

@chkal +1
@spericas What do you think?

@mkarg
Copy link
Contributor

mkarg commented Oct 8, 2018

@kwhat I think you can be happy: I just published JAX-RS 2.1.2 on Maven Central including the fix you requested. :-)

@spericas
Copy link
Contributor

spericas commented Oct 8, 2018

@mkarg Great!

@chkal
Copy link
Contributor

chkal commented Oct 9, 2018

@mkarg Thanks for your weekend work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request project
Projects
None yet
Development

No branches or pull requests

5 participants