Statement getGeneratedKeys

[bosborn]

xerial SQLite JDBC has removed Statement#getGeneratedKeys support in release 3.43.0.0.

Issue: xerial/sqlite-jdbc#329
Commit: xerial/sqlite-jdbc@712a8a5
Discussion: xerial/sqlite-jdbc#959

Would it be possible to replace getGeneratedKeys usage with a RETURNING clause? I did something similar in our library here: ngageoint/geopackage-java@f1579b94f9

ormlite-jdbc/src/main/java/com/j256/ormlite/jdbc/JdbcDatabaseConnection.java

Line 188 in c03005a

ResultSet resultSet = stmt.getGeneratedKeys();

ormlite-jdbc/src/test/java/com/j256/ormlite/jdbc/JdbcDatabaseConnectionTest.java

Line 125 in c03005a

expect(prepStmt.getGeneratedKeys()).andReturn(resultSet);

[bosborn]

Probably the same issue as j256/ormlite-core#288

[bosborn]

Might be resolved by this pull request: xerial/sqlite-jdbc#1035

[Phoenix616]

PR was merged and 3.45.0.0 with it released.

[bosborn]

Version 3.45.0.0 is working for my tests. The fix is to avoid xerial SQLite JDBC versions 3.43.0.0 through 3.44.1.0 (upgrade from 3.42.0.1 or before to 3.45.0.0 or later).

[j256]

Anything that ormlite should be doing here? Should I detect the support for get generated-keys and generate different SQL somehow using sqlite_version() or something?

[Phoenix616]

Ideally DatabaseMetaData#supportsGetGeneratedKeys() would be checked and different code be used if that returns false. For SQLite the issue was fixed in the mentioned Xerial SQLite JDBC driver update so it's not that urgent anymore to adjust in ORMLite but it could be helpful for people trying to use ORMLite with a JDBC driver that doesn't support it.